Source/platform/heap/Heap.h - Issue 1155113002: Oilpan: HeapObjectHeader::checkHeader should not allow access on orphaned pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Heap.h

Issue 1155113002: Oilpan: HeapObjectHeader::checkHeader should not allow access on orphaned pages (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/Heap.h

diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h

index 239139434f5a54ca4023c309674c5c0dd6bf2e3b..312fbd3f8243e2ae05f199193c854f76b1908722 100644

--- a/Source/platform/heap/Heap.h

+++ b/Source/platform/heap/Heap.h

@@ -1164,7 +1164,8 @@ size_t HeapObjectHeader::size() const

NO_SANITIZE_ADDRESS inline

void HeapObjectHeader::checkHeader() const

{

- ASSERT(pageFromObject(this)->orphaned() || m_magic == magic);

+ ASSERT(!pageFromObject(this)->orphaned());

+ ASSERT(m_magic == magic);

}

inline Address HeapObjectHeader::payload()

« no previous file with comments | « no previous file | Source/platform/heap/Heap.cpp » ('j') | no next file with comments »