Move recipe engine to third_party/recipe_engine.

Move recipe engine to third_party/recipe_engine.

This is a step in preparation to move the recipe engine to its own repo. The
main purpose here is to break the tangly links of the recipe engine to the
rest of the build repo, and to begin to define the boundary between the
recipe "engine" and the rest of the recipes.

Supporting internal changes: https://chromereviews.googleplex.com/198277013

TBR for chromium_tests changes, which are trivial.

BUG=459840
TBR=phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295453

[luqui, 2015-05-22 21:00:14]

luqui@chromium.org changed reviewers:
+ iannucci@chromium.org

[luqui, 2015-05-22 21:00:16]

"ptal"  I put some time on your calendar on Tuesday that we can do this
together.  It is a bit much to reconstruct.

[iannucci, 2015-05-27 02:03:27]

lgtm

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/an...
File scripts/slave/annotated_run.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/an...
scripts/slave/annotated_run.py:103: s.step_warnings()
wtf spacing?

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/bo...
File scripts/slave/bot_update.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/bo...
scripts/slave/bot_update.py:3: # Use of this source code is governed by a
BSD-style license that can be
let's do this later :)

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/re...
File scripts/slave/recipe_universe.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/re...
scripts/slave/recipe_universe.py:1: # Copyright (c) 2013 The Chromium Authors.
All rights reserved.
time happened

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/annotated_run.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/annotated_run.py:64: 'failed' is a boolean
representing if the build is in a 'failed' state.
rename to something more appropriate like 'main.py' or something

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/recipe_api.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_api.py:1: # Copyright 2013 The Chromium
Authors. All rights reserved.
drop the recipe_ bit from the name on all these

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/recipe_lint_test.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_lint_test.py:37: r'common\.cros_chromite',
added more modules and they got rebased away or something

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_lint_test.py:69: def main(universe,
whitelist=MODULES_WHITELIST):
y u do whitelist?

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/recipe_simulation_test.py (left):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_simulation_test.py:49:
[os.path.join(os.path.dirname(recipe_util.__file__), 'recipe_api.py')]
lost this?

but really!! we want tests for the engine (for reals), not just happen to cover
the engine via simulation of the user recipes.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/recipe_simulation_test.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_simulation_test.py:14: from . import
expect_tests  # XXX pylint XXX: disable=W0403
????

this looks fine

or move expect_tests to third_party and then this becomes

import expect_tests

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_simulation_test.py:19: _UNIVERSE = None
probably should document that this is a RecipeLoader/RecipeUniverse

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_simulation_test.py:80: # annotated_run has
different behavior when these environment variables
maybe assert universe is something that we can deal with? ducktype'd or
otherwise

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/third_party/annotator.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/third_party/annotator.py:1: #!/usr/bin/env python
don't want the shebang any more

move to ..

[luqui, 2015-05-28 21:47:38]

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/an...
File scripts/slave/annotated_run.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/an...
scripts/slave/annotated_run.py:103: s.step_warnings()
On 2015/05/27 02:03:27, iannucci wrote:
> wtf spacing?

No trouble here. I think it's the new rietveld ui...

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/bo...
File scripts/slave/bot_update.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/bo...
scripts/slave/bot_update.py:3: # Use of this source code is governed by a
BSD-style license that can be
On 2015/05/27 02:03:27, iannucci wrote:
> let's do this later :)

Done.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/re...
File scripts/slave/recipe_universe.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/scripts/slave/re...
scripts/slave/recipe_universe.py:1: # Copyright (c) 2013 The Chromium Authors.
All rights reserved.
On 2015/05/27 02:03:27, iannucci wrote:
> time happened

Acknowledged.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/annotated_run.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/annotated_run.py:64: 'failed' is a boolean
representing if the build is in a 'failed' state.
On 2015/05/27 02:03:27, iannucci wrote:
> rename to something more appropriate like 'main.py' or something

Done.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/recipe_api.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_api.py:1: # Copyright 2013 The Chromium
Authors. All rights reserved.
On 2015/05/27 02:03:27, iannucci wrote:
> drop the recipe_ bit from the name on all these

I chose not to do this for recipe_api and recipe_test_api because the identifier
api became too overloaded, and I ended up "from recipe_engine import api as
recipe_api" all over the place, and it didn't seem worth it.  Besides, the class
is called RecipeApi.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/recipe_lint_test.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_lint_test.py:37: r'common\.cros_chromite',
On 2015/05/27 02:03:27, iannucci wrote:
> added more modules and they got rebased away or something

Done.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_lint_test.py:69: def main(universe,
whitelist=MODULES_WHITELIST):
On 2015/05/27 02:03:27, iannucci wrote:
> y u do whitelist?

It was because e.g. common.skia didn't belong in here. Done.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/recipe_simulation_test.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_simulation_test.py:14: from . import
expect_tests  # XXX pylint XXX: disable=W0403
On 2015/05/27 02:03:27, iannucci wrote:
> ????
> 
> this looks fine
> 
> or move expect_tests to third_party and then this becomes
> 
> import expect_tests

Acknowledged.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_simulation_test.py:19: _UNIVERSE = None
On 2015/05/27 02:03:27, iannucci wrote:
> probably should document that this is a RecipeLoader/RecipeUniverse

Done.

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/recipe_simulation_test.py:80: # annotated_run has
different behavior when these environment variables
On 2015/05/27 02:03:27, iannucci wrote:
> maybe assert universe is something that we can deal with? ducktype'd or
> otherwise

Added docs is all

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
File third_party/recipe_engine/third_party/annotator.py (right):

https://chromiumcodereview.appspot.com/1151423002/diff/40001/third_party/reci...
third_party/recipe_engine/third_party/annotator.py:1: #!/usr/bin/env python
On 2015/05/27 02:03:27, iannucci wrote:
> don't want the shebang any more
> 
> move to ..

Done.

[luqui, 2015-05-28 21:47:52]

The CQ bit was checked by luqui@chromium.org

[luqui, 2015-05-28 21:47:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1151423002/#ps80001
(title: "Review comments")

[commit-bot: I haz the power, 2015-05-28 21:51:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151423002/80001

[commit-bot: I haz the power, 2015-05-28 21:56:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-28 21:56:30]

Presubmit check for 1151423002-80001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\)
)?(2015|2014|2013|2012|2011|2010|2009|2008|2007|2006|2006-2008|2006-2009|2006-2010)
The Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  build/scripts/common/annotator.py

** Presubmit ERRORS **
scripts/slave/unittests/field_composer_test.py (0.65s) failed
Traceback (most recent call last):
  File "scripts/slave/unittests/field_composer_test.py", line 13, in <module>
    from slave import field_composer
ImportError: cannot import name field_composer


Missing LGTM from an OWNER for these files:
    build/scripts/slave/recipe_modules/chromium_tests/api.py
    build/scripts/slave/recipe_modules/chromium_tests/test_api.py

Presubmit checks took 234.3s to calculate.

[luqui, 2015-05-28 23:20:31]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-05-28 23:20:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151423002/80001

[luqui, 2015-05-28 23:20:56]

The CQ bit was unchecked by luqui@chromium.org

[commit-bot: I haz the power, 2015-05-28 23:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-28 23:25:29]

Presubmit check for 1151423002-80001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\)
)?(2015|2014|2013|2012|2011|2010|2009|2008|2007|2006|2006-2008|2006-2009|2006-2010)
The Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  build/scripts/common/annotator.py

** Presubmit ERRORS **
scripts/slave/unittests/field_composer_test.py (0.99s) failed
Traceback (most recent call last):
  File "scripts/slave/unittests/field_composer_test.py", line 13, in <module>
    from slave import field_composer
ImportError: cannot import name field_composer


Presubmit checks took 237.2s to calculate.

[luqui, 2015-05-28 23:26:17]

The CQ bit was checked by luqui@chromium.org

[luqui, 2015-05-28 23:26:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1151423002/#ps100001 (title: "Moved
field_composer_test with its buddies")

[commit-bot: I haz the power, 2015-05-28 23:26:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151423002/100001

[commit-bot: I haz the power, 2015-05-28 23:39:11]

Committed patchset #6 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295453