Move recipe engine to third_party/recipe_engine.

third_party/recipe_engine/recipe_lint_test.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Tests that recipes are on their best behavior.
 
 Checks that recipes only import modules from a whitelist.  Imports are
 generally not safe in recipes if they depend on the platform, since
 e.g. you can run a recipe simulation for a Windows recipe on Linux.
 """
 
 import re
+import os
+import sys
 import types
 
-import test_env  # pylint: disable=W0611,W0403
-
-from slave import recipe_loader
+from . import recipe_loader
 
 
-MODULES_WHITELIST = map(re.compile, [
+MODULES_WHITELIST = [
   r'base64',
   r'collections',
   r'datetime',
   r'json',
   r'math',
   r're',
   r'urlparse',
 
   r'slave\.recipe_api',
 
   # TODO(luqui): Move skia modules into recipe resources
   r'common\.skia\..*',
   r'slave\.skia\..*',
 
   # TODO(luqui): Move cros modules into recipe resources
   r'common\.cros_chromite',

[iannucci, 2015/05/27 02:03:27]

added more modules and they got rebased away or something

[luqui, 2015/05/28 21:47:38]

Done.

-])
+]
 
 
 class ImportViolationError(Exception):
   pass
 
 
 class TestFailure(Exception):
   pass
 
 
-def ImportsTest(recipe_path, recipe_name, universe):
+def ImportsTest(recipe_path, recipe_name, whitelist, universe):
   """Tests that recipe_name only uses allowed imports.
 
   Returns a list of errors, or an empty list if there are no errors (duh).
   """
 
   recipe = universe.load_recipe(recipe_name)
   for attr in dir(recipe):
     val = getattr(recipe, attr)
     if isinstance(val, types.ModuleType):
       module_name = val.__name__
-      for pattern in MODULES_WHITELIST:
+      for pattern in whitelist:
         if pattern.match(val.__name__):
           break
       else:
         yield ('In %s:\n'
                '  Non-whitelisted import of %s' %
                (recipe_path, module_name))
 
 
-def MainTest():
-  universe = recipe_loader.RecipeUniverse()
+def main(universe, whitelist=MODULES_WHITELIST):

[iannucci, 2015/05/27 02:03:27]

y u do whitelist?

[luqui, 2015/05/28 21:47:38]

It was because e.g. common.skia didn't belong in here. Done.

+  whitelist = map(re.compile, whitelist)
 
   errors = []
-  for recipe_path, recipe_name in recipe_loader.loop_over_recipes():
-    errors.extend(ImportsTest(recipe_path, recipe_name, universe))
+  for recipe_path, recipe_name in universe.loop_over_recipes():
+    errors.extend(ImportsTest(recipe_path, recipe_name, whitelist, universe))
 
   if errors:
     raise TestFailure('\n'.join(map(str, errors)))
 
-
-if __name__ == '__main__':
-  MainTest()