chrome/browser/ui/android/infobars/save_password_infobar.cc - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/save_password_infobar.cc

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/infobar_container_android.cc ('k') | chrome/browser/ui/android/infobars/translate_infobar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/save_password_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/save_password_infobar.cc b/chrome/browser/ui/android/infobars/save_password_infobar.cc

index 88e1824cdb4d6e31ca7cde99b87441dc31f7272b..5f181d1233851a93c549da897807afb20706a591 100644

--- a/chrome/browser/ui/android/infobars/save_password_infobar.cc

+++ b/chrome/browser/ui/android/infobars/save_password_infobar.cc

@@ -30,8 +30,8 @@ SavePasswordInfoBar::CreateRenderInfoBar(JNIEnv* env) {

env, save_password_delegate->GetMessageText());

return Java_SavePasswordInfoBar_show(

- env, reinterpret_cast<intptr_t>(this), GetEnumeratedIconId(),

- message_text.obj(), save_password_delegate->title_link_range().start(),

+ env, GetEnumeratedIconId(), message_text.obj(),

+ save_password_delegate->title_link_range().start(),

save_password_delegate->title_link_range().end(), ok_button_text.obj(),

cancel_button_text.obj(), save_password_delegate->ShouldShowMoreButton());

}