chrome/browser/ui/android/infobars/translate_infobar.h - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/translate_infobar.h

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/save_password_infobar.cc ('k') | chrome/browser/ui/android/infobars/translate_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/translate_infobar.h

diff --git a/chrome/browser/ui/android/infobars/translate_infobar.h b/chrome/browser/ui/android/infobars/translate_infobar.h

index e210a0ca84794b94cc0dfa0ba8a073884d5d4a1a..06e514aef723af8f8d5cbe9c2941013f36d158d5 100644

--- a/chrome/browser/ui/android/infobars/translate_infobar.h

+++ b/chrome/browser/ui/android/infobars/translate_infobar.h

@@ -35,16 +35,15 @@ class TranslateInfoBar : public InfoBarAndroid {

JNIEnv* env) override;

void ProcessButton(int action, const std::string& action_value) override;

void PassJavaInfoBar(InfoBarAndroid* source) override;

+ void SetJavaInfoBar(

+ const base::android::JavaRef<jobject>& java_info_bar) override;

void TransferOwnership(TranslateInfoBar* destination,

translate::TranslateStep new_type);

- void SetJavaDelegate(jobject delegate);

bool ShouldDisplayNeverTranslateInfoBarOnCancel();

translate::TranslateInfoBarDelegate* GetDelegate();

- base::android::ScopedJavaGlobalRef<jobject> java_translate_delegate_;

DISALLOW_COPY_AND_ASSIGN(TranslateInfoBar);

};