chrome/browser/ui/android/infobars/infobar_container_android.cc - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/infobar_container_android.cc

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/infobar_android.cc ('k') | chrome/browser/ui/android/infobars/save_password_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/infobar_container_android.cc

diff --git a/chrome/browser/ui/android/infobars/infobar_container_android.cc b/chrome/browser/ui/android/infobars/infobar_container_android.cc

index 7e17d63e036009ef5361061c6745f962d53cc0ab..d30b8eef2899570a5cba2452bef26ac248d430ec 100644

--- a/chrome/browser/ui/android/infobars/infobar_container_android.cc

+++ b/chrome/browser/ui/android/infobars/infobar_container_android.cc

@@ -63,7 +63,7 @@ void InfoBarContainerAndroid::AttachJavaInfoBar(InfoBarAndroid* android_bar) {

android_bar->CreateRenderInfoBar(env);

Java_InfoBarContainer_addInfoBar(

env, weak_java_infobar_container_.get(env).obj(), java_infobar.obj());

- android_bar->set_java_infobar(java_infobar);

+ android_bar->SetJavaInfoBar(java_infobar);

}

void InfoBarContainerAndroid::PlatformSpecificReplaceInfoBar(