chrome/browser/ui/android/infobars/app_banner_infobar_android.cc - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/app_banner_infobar_android.cc

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/account_chooser_infobar.cc ('k') | chrome/browser/ui/android/infobars/confirm_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/app_banner_infobar_android.cc

diff --git a/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc b/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc

index 16e8f14b591e5773400540e7ff4a7b321baf4bfe..cf9847cd8e44ada26217f956090945a98abb5df7 100644

--- a/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc

+++ b/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc

@@ -49,7 +49,6 @@ AppBannerInfoBarAndroid::CreateRenderInfoBar(JNIEnv* env) {

if (!japp_data_.is_null()) {

infobar.Reset(Java_AppBannerInfoBarAndroid_createNativeAppInfoBar(

env,

- reinterpret_cast<intptr_t>(this),

app_title.obj(),

java_bitmap.obj(),

japp_data_.obj()));

@@ -65,7 +64,6 @@ AppBannerInfoBarAndroid::CreateRenderInfoBar(JNIEnv* env) {

infobar.Reset(Java_AppBannerInfoBarAndroid_createWebAppInfoBar(

env,

- reinterpret_cast<intptr_t>(this),

app_title.obj(),

java_bitmap.obj(),

app_url.obj()));