Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: chrome/browser/ui/android/infobars/account_chooser_infobar.cc

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/account_chooser_infobar.cc
diff --git a/chrome/browser/ui/android/infobars/account_chooser_infobar.cc b/chrome/browser/ui/android/infobars/account_chooser_infobar.cc
index 761d5bbf8d6830327331cb7334203cec214c6b5f..758dfbba079aa2363e942508955bf04117a56f12 100644
--- a/chrome/browser/ui/android/infobars/account_chooser_infobar.cc
+++ b/chrome/browser/ui/android/infobars/account_chooser_infobar.cc
@@ -114,8 +114,7 @@ AccountChooserInfoBar::CreateRenderInfoBar(JNIEnv* env) {
GetDelegate()->local_credentials_forms().size());
base::android::ScopedJavaGlobalRef<jobject> java_infobar_global;
java_infobar_global.Reset(Java_AccountChooserInfoBar_show(
- env, reinterpret_cast<intptr_t>(this), GetEnumeratedIconId(),
- java_credentials_array.obj()));
+ env, GetEnumeratedIconId(), java_credentials_array.obj()));
base::android::ScopedJavaLocalRef<jobject> java_infobar(java_infobar_global);
content::WebContents* web_contents =
InfoBarService::WebContentsFromInfoBar(this);
@@ -153,6 +152,14 @@ AccountChooserInfoBarDelegateAndroid* AccountChooserInfoBar::GetDelegate() {
return static_cast<AccountChooserInfoBarDelegateAndroid*>(delegate());
}
+void AccountChooserInfoBar::SetJavaInfoBar(
+ const base::android::JavaRef<jobject>& java_info_bar) {
+ InfoBarAndroid::SetJavaInfoBar(java_info_bar);
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_AccountChooserInfoBar_setNativePtr(env, java_info_bar.obj(),
+ reinterpret_cast<intptr_t>(this));
+}
+
bool RegisterAccountChooserInfoBar(JNIEnv* env) {
return RegisterNativesImpl(env);
}

Powered by Google App Engine
This is Rietveld 408576698