chrome/browser/ui/android/infobars/confirm_infobar.cc - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/confirm_infobar.cc

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unrelated file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/app_banner_infobar_android.cc ('k') | chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/confirm_infobar.cc

diff --git a/chrome/browser/ui/android/infobars/confirm_infobar.cc b/chrome/browser/ui/android/infobars/confirm_infobar.cc

index 149e0de1dc687713613283a2b2be65c55bfbe765..9fef5cf2b9c7ef697663bec84328d9f77c84f778 100644

--- a/chrome/browser/ui/android/infobars/confirm_infobar.cc

+++ b/chrome/browser/ui/android/infobars/confirm_infobar.cc

@@ -54,9 +54,9 @@ base::android::ScopedJavaLocalRef<jobject> ConfirmInfoBar::CreateRenderInfoBar(

}

return Java_ConfirmInfoBarDelegate_showConfirmInfoBar(

- env, java_confirm_delegate_.obj(), reinterpret_cast<intptr_t>(this),

- GetEnumeratedIconId(), java_bitmap.obj(), message_text.obj(),

- link_text.obj(), ok_button_text.obj(), cancel_button_text.obj());

+ env, java_confirm_delegate_.obj(), GetEnumeratedIconId(),

+ java_bitmap.obj(), message_text.obj(), link_text.obj(),

+ ok_button_text.obj(), cancel_button_text.obj());

}

void ConfirmInfoBar::OnLinkClicked(JNIEnv* env, jobject obj) {