Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBar.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBar.java
index f43c8ef6f0fcf5cd2b81dedb6f153377f0338738..cba284c11d987b5ee12bbd738ee22d788083d78e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBar.java
@@ -20,17 +20,15 @@ public class GeneratedPasswordSavedInfoBar extends InfoBar {
/**
* Creates and shows the infobar to notify that the generated password was saved.
- * @param nativeInfoBar Pointer to the native infobar.
* @param iconDrawableId Drawable ID corresponding to the icon that the infobar will show.
* @param messageText Message to display in the infobar.
* @param inlineLinkRangeStart The start of the range of the messageText that should be a link.
* @param inlineLinkRangeEnd The end of the range of the messageText that should be a link.
* @param buttonLabel String to display on the button.
*/
- public GeneratedPasswordSavedInfoBar(long nativeInfoBar, int iconDrawableId, String messageText,
+ public GeneratedPasswordSavedInfoBar(int iconDrawableId, String messageText,
int inlineLinkRangeStart, int inlineLinkRangeEnd, String buttonLabel) {
super(null, iconDrawableId, null, null);
- setNativeInfoBar(nativeInfoBar);
mMessageText = messageText;
mInlineLinkRangeStart = inlineLinkRangeStart;
mInlineLinkRangeEnd = inlineLinkRangeEnd;
@@ -62,15 +60,6 @@ public class GeneratedPasswordSavedInfoBar extends InfoBar {
*/
@Override
public void onButtonClicked(boolean isPrimaryButton) {
- nativeOnButtonClicked(mNativeInfoBarPtr, InfoBar.ACTION_TYPE_OK, "");
- }
-
- /**
- * Called when the close button is clicked. Notifies the native infobar, which closes the
- * infobar.
- */
- @Override
- public void onCloseButtonClicked() {
- nativeOnCloseButtonClicked(mNativeInfoBarPtr);
+ onButtonClicked(InfoBar.ACTION_TYPE_OK, "");
}
}

Powered by Google App Engine
This is Rietveld 408576698