Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java
index db4cac5c1737b3e868f7006f354223e48f07f5c9..6f0240ba9d35179bc32b70fc41592f00461c8170 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/GeneratedPasswordSavedInfoBarDelegate.java
@@ -13,7 +13,6 @@ import org.chromium.chrome.browser.ResourceId;
public class GeneratedPasswordSavedInfoBarDelegate {
/**
* Creates and shows the infobar to notify that the generated password was saved.
- * @param nativeInfoBar Pointer to the native infobar.
* @param enumeratedIconId Enum ID corresponding to the icon that the infobar will show.
* @param messageText Message to display in the infobar.
* @param inlineLinkRangeStart The start of the range of the messageText that should be a link.
@@ -21,10 +20,9 @@ public class GeneratedPasswordSavedInfoBarDelegate {
* @param buttonLabel String to display on the button.
*/
@CalledByNative
- private static InfoBar show(long nativeInfoBar, int enumeratedIconId, String messageText,
- int inlineLinkRangeStart, int inlineLinkRangeEnd, String buttonLabel) {
- return new GeneratedPasswordSavedInfoBar(nativeInfoBar,
- ResourceId.mapToDrawableId(enumeratedIconId), messageText, inlineLinkRangeStart,
- inlineLinkRangeEnd, buttonLabel);
+ private static InfoBar show(int enumeratedIconId, String messageText, int inlineLinkRangeStart,
+ int inlineLinkRangeEnd, String buttonLabel) {
+ return new GeneratedPasswordSavedInfoBar(ResourceId.mapToDrawableId(enumeratedIconId),
+ messageText, inlineLinkRangeStart, inlineLinkRangeEnd, buttonLabel);
}
}

Powered by Google App Engine
This is Rietveld 408576698