Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java
index c16e0eaaf875fbde97f15825dcc692ff402a8980..5aa601fd3eb8d6b33cbd65f24dabffb21d901211 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java
@@ -33,37 +33,28 @@ public class DownloadOverwriteInfoBar extends InfoBar {
private final String mDirFullPath;
@CalledByNative
- private static InfoBar createInfoBar(
- long nativeInfoBar, String fileName, String dirName, String dirFullPath) {
- return new DownloadOverwriteInfoBar(nativeInfoBar, fileName, dirName, dirFullPath);
+ private static InfoBar createInfoBar(String fileName, String dirName, String dirFullPath) {
+ return new DownloadOverwriteInfoBar(fileName, dirName, dirFullPath);
}
/**
* Constructs DownloadOverwriteInfoBar.
- * @param nativeInfoBarPtr Pointer value of the native infobar.
* @param fileName The file name. ex) example.jpg
* @param dirName The dir name. ex) Downloads
* @param dirFullPath The full dir path. ex) sdcards/Downloads
*/
- private DownloadOverwriteInfoBar(
- long nativeInfoBarPtr, String fileName, String dirName, String dirFullPath) {
+ private DownloadOverwriteInfoBar(String fileName, String dirName, String dirFullPath) {
super(null, R.drawable.infobar_downloading, null, null);
mFileName = fileName;
mDirName = dirName;
mDirFullPath = dirFullPath;
- setNativeInfoBar(nativeInfoBarPtr);
- }
-
- @Override
- public void onCloseButtonClicked() {
- if (mNativeInfoBarPtr != 0) nativeOnCloseButtonClicked(mNativeInfoBarPtr);
}
@Override
public void onButtonClicked(boolean isPrimaryButton) {
int action = isPrimaryButton ? InfoBar.ACTION_TYPE_OVERWRITE
: InfoBar.ACTION_TYPE_CREATE_NEW_FILE;
- if (mNativeInfoBarPtr != 0) nativeOnButtonClicked(mNativeInfoBarPtr, action, "");
+ onButtonClicked(action, "");
}
private CharSequence getMessageText(Context context) {

Powered by Google App Engine
This is Rietveld 408576698