Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 11418120: Release video resources when switching tabs or leave clank (Closed)

Created:
8 years, 1 month ago by qinmin
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Release video resources when switching tabs or leave clank The media framework prefer at most 2 players playing. Release video decoding resources when switching tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169505

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 2 comments Download
M webkit/media/android/webmediaplayer_manager_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/media/android/webmediaplayer_manager_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
qinmin
PTAL
8 years, 1 month ago (2012-11-21 19:22:03 UTC) #1
scherkus (not reviewing)
https://codereview.chromium.org/11418120/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/11418120/diff/1/content/renderer/render_view_impl.cc#newcode5732 content/renderer/render_view_impl.cc:5732: media_player_manager_->ReleaseMediaResources(); would it be more accurate to call this ...
8 years, 1 month ago (2012-11-21 21:44:30 UTC) #2
qinmin
https://codereview.chromium.org/11418120/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/11418120/diff/1/content/renderer/render_view_impl.cc#newcode5732 content/renderer/render_view_impl.cc:5732: media_player_manager_->ReleaseMediaResources(); I think video is not correct, as it ...
8 years, 1 month ago (2012-11-21 21:53:53 UTC) #3
scherkus (not reviewing)
OK -- LGTM
8 years, 1 month ago (2012-11-21 22:24:41 UTC) #4
brettw
owners lgtm rubberstamp
8 years ago (2012-11-26 19:20:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/11418120/1
8 years ago (2012-11-26 19:26:34 UTC) #6
commit-bot: I haz the power
8 years ago (2012-11-26 22:25:31 UTC) #7
Message was sent while issue was closed.
Change committed as 169505

Powered by Google App Engine
This is Rietveld 408576698