Release video resources when switching tabs or leave clank

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/bind.h"
@@ skipping 5707 matching lines @@
 
 void RenderViewImpl::DidHandleTouchEvent(const WebTouchEvent& event) {
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidHandleTouchEvent(event));
 }
 
 void RenderViewImpl::OnWasHidden() {
   RenderWidget::OnWasHidden();
 
 #if defined(OS_ANDROID)
   // Inform WebMediaPlayerManagerAndroid to release all media player resources.
-  // unless some media is playing.
+  // unless some audio is playing.
   // If something is in progress the resource will not be freed, it will
   // only be freed once the tab is destroyed or if the user navigates away
   // via WebMediaPlayerAndroid::Destroy
-  media_player_manager_->ReleaseMediaResourcesIfNotPlaying();
+  media_player_manager_->ReleaseMediaResources();

[scherkus (not reviewing), 2012/11/21 21:44:30]

would it be more accurate to call this "ReleaseVideoResources()" seeing as this
no-ops if it's only audio?

[qinmin, 2012/11/21 21:53:54]

I think video is not correct, as it also released paused audio decoders.

On 2012/11/21 21:44:30, scherkus wrote:

 #endif
 
   if (webview()) {
     webview()->settings()->setMinimumTimerInterval(
         webkit_glue::kBackgroundTabTimerInterval);
     webview()->setVisibilityState(visibilityState(), false);
   }
 
   // Inform PPAPI plugins that their page is no longer visible.
   pepper_delegate_.PageVisibilityChanged(false);
@@ skipping 666 matching lines @@
 }
 #endif
 
 void RenderViewImpl::OnReleaseDisambiguationPopupDIB(
     TransportDIB::Handle dib_handle) {
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }
 
 }  // namespace content