Issue 11417145: Provide a safer URLLoader ReadResponseBody API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11417145: Provide a safer URLLoader ReadResponseBody API (Closed)

Created:
8 years, 1 month ago by victorhsieh

Modified:
7 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Provide a safer URLLoader ReadResponseBody API ReadResponseBodyToArray is added in URLLoader 1.1 for that. BUG=155397

Patch Set 1 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+570 lines, -97 lines)			Patch
M	chrome/test/ppapi/ppapi_browsertest.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	ppapi/api/ppb_url_loader.idl	View	3 chunks	+29 lines, -1 line	0 comments	Download
M	ppapi/c/ppb_url_loader.h	View	5 chunks	+54 lines, -4 lines	0 comments	Download
M	ppapi/cpp/file_io.h	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	ppapi/cpp/url_loader.h	View	4 chunks	+48 lines, -0 lines	0 comments	Download
M	ppapi/cpp/url_loader.cc	View	4 chunks	+118 lines, -38 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	5 chunks	+92 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_url_loader_proxy.cc	View	12 chunks	+73 lines, -36 lines	0 comments	Download
M	ppapi/tests/test_url_loader.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ppapi/tests/test_url_loader.cc	View	4 chunks	+60 lines, -0 lines	0 comments	Download
M	ppapi/thunk/interfaces_ppb_public_stable.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/thunk/ppb_url_loader_api.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ppapi/thunk/ppb_url_loader_thunk.cc	View	3 chunks	+31 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_loader_impl.h	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_loader_impl.cc	View	7 chunks	+40 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

victorhsieh

8 years ago (2012-11-26 07:12:04 UTC) #1

browser_tests all passed.  With the fallback implementation, they also passed.

Expand Messages | Collapse Messages