Provide a safer URLLoader ReadResponseBody API

webkit/plugins/ppapi/ppb_url_loader_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_URL_LOADER_IMPL_H_
 #define WEBKIT_PLUGINS_PPAPI_PPB_URL_LOADER_IMPL_H_
 
 #include <deque>
 
 #include "base/memory/ref_counted.h"
@@ skipping 39 matching lines @@
   virtual PP_Bool GetUploadProgress(int64_t* bytes_sent,
                                     int64_t* total_bytes_to_be_sent) OVERRIDE;
   virtual PP_Bool GetDownloadProgress(
       int64_t* bytes_received,
       int64_t* total_bytes_to_be_received) OVERRIDE;
   virtual PP_Resource GetResponseInfo() OVERRIDE;
   virtual int32_t ReadResponseBody(
       void* buffer,
       int32_t bytes_to_read,
       scoped_refptr< ::ppapi::TrackedCallback> callback) OVERRIDE;
+  virtual int32_t ReadResponseBodyToArray(
+      int32_t max_read_length,
+      PP_ArrayOutput* array_output,
+      scoped_refptr< ::ppapi::TrackedCallback> callback) OVERRIDE;
   virtual int32_t FinishStreamingToFile(
       scoped_refptr< ::ppapi::TrackedCallback> callback) OVERRIDE;
   virtual void Close() OVERRIDE;
   virtual void GrantUniversalAccess() OVERRIDE;
   virtual void SetStatusCallback(
       PP_URLLoaderTrusted_StatusCallback cb) OVERRIDE;
   virtual bool GetResponseInfoData(
       ::ppapi::URLResponseInfoData* data) OVERRIDE;
 
+  int32_t ReadResponseBodyInternal(
+      int32_t max_read_length,
+      const PP_ArrayOutput& array_output,
+      scoped_refptr< ::ppapi::TrackedCallback> callback);
+
   // WebKit::WebURLLoaderClient implementation.
   virtual void willSendRequest(WebKit::WebURLLoader* loader,
                                WebKit::WebURLRequest& new_request,
                                const WebKit::WebURLResponse& redir_response);
   virtual void didSendData(WebKit::WebURLLoader* loader,
                            unsigned long long bytes_sent,
                            unsigned long long total_bytes_to_be_sent);
   virtual void didReceiveResponse(WebKit::WebURLLoader* loader,
                                   const WebKit::WebURLResponse& response);
   virtual void didDownloadData(WebKit::WebURLLoader* loader,
@@ skipping 65 matching lines @@
   // document load, you would call the functions on the document to cancel the
   // load, etc. since there is no loader.
   scoped_ptr<WebKit::WebURLLoader> loader_;
 
   scoped_refptr< ::ppapi::TrackedCallback> pending_callback_;
   std::deque<char> buffer_;
   int64_t bytes_sent_;
   int64_t total_bytes_to_be_sent_;
   int64_t bytes_received_;
   int64_t total_bytes_to_be_received_;
-  char* user_buffer_;
+  scoped_ptr<PP_ArrayOutput> user_buffer_;
   size_t user_buffer_size_;
   int32_t done_status_;
   bool is_streaming_to_file_;
   bool is_asynchronous_load_suspended_;
 
   bool has_universal_access_;
 
   PP_URLLoaderTrusted_StatusCallback status_callback_;
 
   // When the response info is received, this stores the data. The
   // ScopedResource maintains the reference to the file ref (if any) in the
   // data object so we don't forget to dereference it.
   scoped_ptr< ::ppapi::URLResponseInfoData > response_info_;
   ::ppapi::ScopedPPResource response_info_file_ref_;
 
   DISALLOW_COPY_AND_ASSIGN(PPB_URLLoader_Impl);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPB_URL_LOADER_IMPL_H_