Issue 11416261: Clean Up: remove unused variable selection_item_id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11416261: Clean Up: remove unused variable selection_item_id (Closed)

Created:
8 years ago by Seigo Nonaka

Modified:
8 years ago

Reviewers:
satorux1

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean Up: remove unused variable selection_item_id There is no usage of selection_item_id and radio grouping logic is in engine. So it is safe to remove selection_item_id from Chrome. I checked property behaviors and there is no regression on Japanese/Simplified Chinese/Traditional Chinese/Hangul. (including radio handling, property order, activation handling etc...) I also checked any properties in all m17n engines, but there is no property. BUG=None TEST=Manually done on lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170496

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -80 lines)			Patch
M	chrome/browser/chromeos/input_method/ibus_controller_impl.cc	View	5 chunks	+21 lines, -41 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_property.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_property.cc	View	3 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_property_unittest.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11416261/1

8 years ago (2012-11-30 16:41:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11416261/1

8 years ago (2012-11-30 17:12:53 UTC) #4

Message was sent while issue was closed.

Change committed as 170496

Expand Messages | Collapse Messages