chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc - Issue 11416261: Clean Up: remove unused variable selection_item_id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc

Issue 11416261: Clean Up: remove unused variable selection_item_id (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/ibus_controller_impl.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc b/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc

index dc0317063c2e81a32a867d5c99e1a5683b650e63..e3b16400d54b54a40c65a5a82513a50150162bb0 100644

--- a/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc

+++ b/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc

@@ -25,27 +25,27 @@ TEST(IBusControllerImplTest, TestFindAndUpdateProperty) {

EXPECT_FALSE(FindAndUpdateProperty(InputMethodProperty(), &properties));

properties.push_back(

- InputMethodProperty("key1", "label1", false, false, 0));

+ InputMethodProperty("key1", "label1", false, false));

EXPECT_FALSE(FindAndUpdateProperty(InputMethodProperty(), &properties));

EXPECT_FALSE(FindAndUpdateProperty(

- InputMethodProperty("keyX", "labelX", false, false, 0), &properties));

- EXPECT_EQ(InputMethodProperty("key1", "label1", false, false, 0),

+ InputMethodProperty("keyX", "labelX", false, false), &properties));

+ EXPECT_EQ(InputMethodProperty("key1", "label1", false, false),

properties[0]);

EXPECT_TRUE(FindAndUpdateProperty(

- InputMethodProperty("key1", "labelY", false, false, 0), &properties));

- EXPECT_EQ(InputMethodProperty("key1", "labelY", false, false, 0),

+ InputMethodProperty("key1", "labelY", false, false), &properties));

+ EXPECT_EQ(InputMethodProperty("key1", "labelY", false, false),

properties[0]);

properties.push_back(

- InputMethodProperty("key2", "label2", false, false, 0));

+ InputMethodProperty("key2", "label2", false, false));

EXPECT_FALSE(FindAndUpdateProperty(InputMethodProperty(), &properties));

EXPECT_FALSE(FindAndUpdateProperty(

- InputMethodProperty("keyX", "labelX", false, false, 0), &properties));

- EXPECT_EQ(InputMethodProperty("key2", "label2", false, false, 0),

+ InputMethodProperty("keyX", "labelX", false, false), &properties));

+ EXPECT_EQ(InputMethodProperty("key2", "label2", false, false),

properties[1]);

EXPECT_TRUE(FindAndUpdateProperty(

- InputMethodProperty("key2", "labelZ", false, false, 0), &properties));

- EXPECT_EQ(InputMethodProperty("key2", "labelZ", false, false, 0),

+ InputMethodProperty("key2", "labelZ", false, false), &properties));

+ EXPECT_EQ(InputMethodProperty("key2", "labelZ", false, false),

properties[1]);

}