Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3720)

Unified Diff: chrome/browser/chromeos/input_method/input_method_property.cc

Issue 11416261: Clean Up: remove unused variable selection_item_id (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_property.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_property.cc b/chrome/browser/chromeos/input_method/input_method_property.cc
index caab50edbbdd223648e1d5d3772d40e588afb7bc..46f4d7c3f67eb6cafa553ab49e074e32cd0c83ab 100644
--- a/chrome/browser/chromeos/input_method/input_method_property.cc
+++ b/chrome/browser/chromeos/input_method/input_method_property.cc
@@ -14,20 +14,17 @@ namespace input_method {
InputMethodProperty::InputMethodProperty(const std::string& in_key,
const std::string& in_label,
bool in_is_selection_item,
- bool in_is_selection_item_checked,
- int in_selection_item_id)
+ bool in_is_selection_item_checked)
: key(in_key),
label(in_label),
is_selection_item(in_is_selection_item),
- is_selection_item_checked(in_is_selection_item_checked),
- selection_item_id(in_selection_item_id) {
+ is_selection_item_checked(in_is_selection_item_checked) {
DCHECK(!key.empty());
}
InputMethodProperty::InputMethodProperty()
: is_selection_item(false),
- is_selection_item_checked(false),
- selection_item_id(kInvalidSelectionItemId) {
+ is_selection_item_checked(false) {
}
InputMethodProperty::~InputMethodProperty() {
@@ -37,8 +34,7 @@ bool InputMethodProperty::operator==(const InputMethodProperty& other) const {
return key == other.key &&
label == other.label &&
is_selection_item == other.is_selection_item &&
- is_selection_item_checked == other.is_selection_item_checked &&
- selection_item_id == other.selection_item_id;
+ is_selection_item_checked == other.is_selection_item_checked;
}
bool InputMethodProperty::operator!=(const InputMethodProperty& other) const {
@@ -50,8 +46,7 @@ std::string InputMethodProperty::ToString() const {
stream << "key=" << key
<< ", label=" << label
<< ", is_selection_item=" << is_selection_item
- << ", is_selection_item_checked=" << is_selection_item_checked
- << ", selection_item_id=" << selection_item_id;
+ << ", is_selection_item_checked=" << is_selection_item_checked;
return stream.str();
}

Powered by Google App Engine
This is Rietveld 408576698