Move the test functions that deal with focus to interactive_ui_tets_utils.h and into the interactiv…

Move the test functions that deal with focus to interactive_ui_tets_utils.h and into the interactive_ui_tests target. That way they can't be misused from browser_tests.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170224

[jam, 2012-11-29 07:06:42]

https://codereview.chromium.org/11414223/diff/7011/chrome/test/gpu/gpu_mapsgl...
File chrome/test/gpu/gpu_mapsgl_endurance_browsertest.cc (right):

https://codereview.chromium.org/11414223/diff/7011/chrome/test/gpu/gpu_mapsgl...
chrome/test/gpu/gpu_mapsgl_endurance_browsertest.cc:83:
browser()->window()->Activate();
this was copied from gpu_pixel_browsertest.cc

https://codereview.chromium.org/11414223/diff/7011/chrome/test/gpu/gpu_pixel_...
File chrome/test/gpu/gpu_pixel_browsertest.cc (right):

https://codereview.chromium.org/11414223/diff/7011/chrome/test/gpu/gpu_pixel_...
chrome/test/gpu/gpu_pixel_browsertest.cc:170: browser()->window()->Activate();
this was how it was originally written in the codereview at
http://codereview.chromium.org/9107014/diff/1/chrome/test/gpu/gpu_pixel_brows...,
so I take that to mean that this works as well.

[sky, 2012-11-29 16:49:18]

I'm a bit worried we're missing something. How have all of these been working on
the win bots to date?

[jam, 2012-11-29 16:58:08]

On 2012/11/29 16:49:18, sky wrote:
> I'm a bit worried we're missing something. How have all of these been working
on
> the win bots to date?

I'm not sure what you mean? Do you mean how were the tests that used these
working before?

A test that depends on focus can still work with sharding_supervisor because of
two things: the first time it runs, it could just happen to be able to bring
itself to focus and do whatever is needed before another test runs. This is of
course very racy. The bigger reason that hides these problems though is that
sharding_supervisor reruns failed tests at the end in serial.

[sky, 2012-11-29 17:18:46]

LGTM