Move the test functions that deal with focus to interactive_ui_tets_utils.h and into the interactiv…

chrome/browser/autofill/autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 432 matching lines @@
 #if defined(OS_MACOSX)
 #define MAYBE_AutofillViaDownArrow AutofillViaDownArrow
 #else
 #define MAYBE_AutofillViaDownArrow DISABLED_AutofillViaDownArrow
 #endif
 // Test that form filling can be initiated by pressing the down arrow.
 IN_PROC_BROWSER_TEST_F(AutofillTest, MAYBE_AutofillViaDownArrow) {
   CreateTestProfile();
 
   // Load the test page.
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) + kTestFormString)));
 
   // Focus a fillable field.
   FocusFirstNameField();
 
   // Press the down arrow to initiate Autofill and wait for the popup to be
   // shown.
   SendKeyAndWait(
       ui::VKEY_DOWN, chrome::NOTIFICATION_AUTOFILL_DID_SHOW_SUGGESTIONS);
@@ skipping 36 matching lines @@
       "document.getElementById('state').onchange = function() {"
       "  changed_select_fired = true;"
       "};"
       "document.getElementById('country').onchange = function() {"
       "  unchanged_select_fired = true;"
       "};"
       "document.getElementById('country').value = 'US';"
       "</script>";
 
   // Load the test page.
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) + kTestFormString + kOnChangeScript)));
 
   // Invoke Autofill.
   FocusFirstNameField();
 
   // Start filling the first name field with "M" and wait for the popup to be
   // shown.
   SendKeyAndWait(
       ui::VKEY_M, chrome::NOTIFICATION_AUTOFILL_DID_SHOW_SUGGESTIONS);
@@ skipping 54 matching lines @@
       std::string(kDataURIPrefix) + kTestFormString +
       "<script>"
       "var mainForm = document.forms[0];"
       "mainForm.id = 'mainForm';"
       "var newForm = document.createElement('form');"
       "newForm.action = mainForm.action;"
       "newForm.method = mainForm.method;"
       "newForm.id = 'newForm';"
       "mainForm.parentNode.insertBefore(newForm, mainForm);"
       "</script>";
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(), GURL(kURL)));
 
   // Invoke Autofill.
   TryBasicFormFill();
 }
 
 // Test that we properly autofill forms with repeated fields.
 // In the wild, the repeated fields are typically either email fields
 // (duplicated for "confirmation"); or variants that are hot-swapped via
 // JavaScript, with only one actually visible at any given time.
 // DISABLED: http://crbug.com/150084
 IN_PROC_BROWSER_TEST_F(AutofillTest, DISABLED_AutofillFormWithRepeatedField) {
   CreateTestProfile();
 
   // Load the test page.
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) +
            "<form action=\"http://www.example.com/\" method=\"POST\">"
            "<label for=\"firstname\">First name:</label>"
            " <input type=\"text\" id=\"firstname\""
            "        onFocus=\"domAutomationController.send(true)\"><br>"
            "<label for=\"lastname\">Last name:</label>"
            " <input type=\"text\" id=\"lastname\"><br>"
            "<label for=\"address1\">Address line 1:</label>"
            " <input type=\"text\" id=\"address1\"><br>"
@@ skipping 35 matching lines @@
 #define MAYBE_AutofillFormWithNonAutofillableField \
     DISABLED_AutofillFormWithNonAutofillableField
 #endif
 
 // Test that we properly autofill forms with non-autofillable fields.
 IN_PROC_BROWSER_TEST_F(AutofillTest,
                        MAYBE_AutofillFormWithNonAutofillableField) {
   CreateTestProfile();
 
   // Load the test page.
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) +
            "<form action=\"http://www.example.com/\" method=\"POST\">"
            "<label for=\"firstname\">First name:</label>"
            " <input type=\"text\" id=\"firstname\""
            "        onFocus=\"domAutomationController.send(true)\"><br>"
            "<label for=\"middlename\">Middle name:</label>"
            " <input type=\"text\" id=\"middlename\" autocomplete=\"off\" /><br>"
            "<label for=\"lastname\">Last name:</label>"
            " <input type=\"text\" id=\"lastname\"><br>"
@@ skipping 24 matching lines @@
   // Invoke Autofill.
   TryBasicFormFill();
 }
 
 // Test that we can Autofill dynamically generated forms.
 // DISABLED: http://crbug.com/150084
 IN_PROC_BROWSER_TEST_F(AutofillTest, DISABLED_DynamicFormFill) {
   CreateTestProfile();
 
   // Load the test page.
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) +
            "<form id=\"form\" action=\"http://www.example.com/\""
            "      method=\"POST\"></form>"
            "<script>"
            "function AddElement(name, label) {"
            "  var form = document.getElementById('form');"
            ""
            "  var label_text = document.createTextNode(label);"
            "  var label_element = document.createElement('label');"
@@ skipping 78 matching lines @@
 #define MAYBE_AutofillAfterReload AutofillAfterReload
 #else
 #define MAYBE_AutofillAfterReload DISABLED_AutofillAfterReload
 #endif
 IN_PROC_BROWSER_TEST_F(AutofillTest, MAYBE_AutofillAfterReload) {
   LOG(WARNING) << "Creating test profile.";
   CreateTestProfile();
 
   // Load the test page.
   LOG(WARNING) << "Bringing browser window to front.";
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   LOG(WARNING) << "Navigating to URL.";
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
       GURL(std::string(kDataURIPrefix) + kTestFormString)));
 
   // Reload the page.
   LOG(WARNING) << "Reloading the page.";
   WebContents* tab = chrome::GetActiveWebContents(browser());
   tab->GetController().Reload(false);
   content::WaitForLoadStop(tab);
 
@@ skipping 30 matching lines @@
                " <input type=\"text\" id=\"z\"><br>"
                "<label for=\"co\">Country:</label>"
                " <select id=\"co\">"
                " <option value=\"\" selected=\"yes\">--</option>"
                " <option value=\"CA\">Canada</option>"
                " <option value=\"US\">United States</option>"
                " </select><br>"
                "<label for=\"ph\">Phone number:</label>"
                " <input type=\"text\" id=\"ph\"><br>"
                "</form>");
-  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(), url));
 
   // Get translation bar.
   RenderViewHostTester::TestOnMessageReceived(
       render_view_host(),
       ChromeViewHostMsg_TranslateLanguageDetermined(0, "ja", true));
   TranslateInfoBarDelegate* infobar =
       InfoBarService::FromWebContents(chrome::GetActiveWebContents(browser()))->
           GetInfoBarDelegateAt(0)->AsTranslateInfoBarDelegate();
 
@@ skipping 739 matching lines @@
 // TODO(isherman): this looks redundant, consider removing.
 // DISABLED: http://crbug.com/150084
 IN_PROC_BROWSER_TEST_F(AutofillTest,
                        DISABLED_MergeAggregatedDuplicatedProfiles) {
   int num_of_profiles =
       AggregateProfilesIntoAutofillPrefs("dataset_no_address.txt");
 
   ASSERT_GT(num_of_profiles,
             static_cast<int>(personal_data_manager()->profiles().size()));
 }