src/heap.cc - Issue 11413142: Fix array concat for holey arrays and concat of double to object arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 11413142: Fix array concat for holey arrays and concat of double to object arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 976d65e959fdc35e50a8efe8964ff9e00a1388c4..d31016c0dc02fbadb0452127f8263fe18db74eb5 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -4232,9 +4232,6 @@ MaybeObject* Heap::AllocateJSArrayAndStorage(

ArrayStorageAllocationMode mode,

PretenureFlag pretenure) {

ASSERT(capacity >= length);

- if (length != 0 && mode == INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE) {

- elements_kind = GetHoleyElementsKind(elements_kind);

- }

MaybeObject* maybe_array = AllocateJSArray(elements_kind, pretenure);

JSArray* array;

if (!maybe_array->To(&array)) return maybe_array;

« no previous file with comments | « src/factory.cc ('k') | src/objects.cc » ('j') | no next file with comments »