src/factory.cc - Issue 11413142: Fix array concat for holey arrays and concat of double to object arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 11413142: Fix array concat for holey arrays and concat of double to object arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 5e38d06a8fda45816b5cd2733cafc6787fedf77f..556f2b01b793bc11c45a1c0a1f094e57b02ff835 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -950,6 +950,9 @@ Handle<JSObject> Factory::NewJSObjectFromMap(Handle<Map> map) {

Handle<JSArray> Factory::NewJSArray(int capacity,

ElementsKind elements_kind,

PretenureFlag pretenure) {

+ if (capacity != 0) {

+ elements_kind = GetHoleyElementsKind(elements_kind);

+ }

CALL_HEAP_FUNCTION(isolate(),

isolate()->heap()->AllocateJSArrayAndStorage(

elements_kind,

« no previous file with comments | « src/builtins.cc ('k') | src/heap.cc » ('j') | no next file with comments »