src/objects.cc - Issue 11413142: Fix array concat for holey arrays and concat of double to object arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 11413142: Fix array concat for holey arrays and concat of double to object arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 05c00824009233bb90642c648d78d262f6a73e17..78560df6310daf2f6084417616c580cfde7eb2c4 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -10489,6 +10489,8 @@ MaybeObject* JSObject::TransitionElementsKind(ElementsKind to_kind) {

to_kind = GetHoleyElementsKind(to_kind);

}

+ if (from_kind == to_kind) return this;

Isolate* isolate = GetIsolate();

if (elements() == isolate->heap()->empty_fixed_array() ||

(IsFastSmiOrObjectElementsKind(from_kind) &&

« no previous file with comments | « src/heap.cc ('k') | no next file » | no next file with comments »