cc: Make RenderPass into a struct-like class.

cc: Make RenderPass into a struct-like class.

This follows the same pattern as DrawQuad and SharedQuadState. The Create()
method takes no parameters, allowing the IPC code to create an empty RenderPass.

Then we have SetNew() and SetAll() methods to set the the properties of the
RenderPass when creating a new one, or when recreating one via IPC,
respectively.

Covered by existing tests.

BUG=152337
TBR=aelias


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168998

[aelias_OOO_until_Jul13, 2012-11-21 01:50:10]

https://codereview.chromium.org/11413106/diff/4001/cc/render_pass.cc
File cc/render_pass.cc (right):

https://codereview.chromium.org/11413106/diff/4001/cc/render_pass.cc#newcode93
cc/render_pass.cc:93: void RenderPass::AppendQuadsForLayer(
These methods aren't very readable without the "m_"s.  Local and member
variables are mixed together.  And they only operate on
m_quadList/m_sharedQuadStateList anyway.

I'm thinking we should probably move them out of the class.  Maybe make them
anonymous namespace functions in layer_tree_host_impl.cc?

https://codereview.chromium.org/11413106/diff/4001/cc/render_pass.cc#newcode176
cc/render_pass.cc:176: Region::Iterator fill_rects(fill_region);
nit: why not keep this inside the for()?

[danakj, 2012-11-21 01:53:02]

https://codereview.chromium.org/11413106/diff/4001/cc/render_pass.cc
File cc/render_pass.cc (right):

https://codereview.chromium.org/11413106/diff/4001/cc/render_pass.cc#newcode93
cc/render_pass.cc:93: void RenderPass::AppendQuadsForLayer(
On 2012/11/21 01:50:10, aelias wrote:
> These methods aren't very readable without the "m_"s.  Local and member
> variables are mixed together.  And they only operate on
> m_quadList/m_sharedQuadStateList anyway.
> 
> I'm thinking we should probably move them out of the class.  Maybe make them
> anonymous namespace functions in layer_tree_host_impl.cc?

Ya that's reasonable, they aren't used by tests.

https://codereview.chromium.org/11413106/diff/4001/cc/render_pass.cc#newcode176
cc/render_pass.cc:176: Region::Iterator fill_rects(fill_region);
On 2012/11/21 01:50:10, aelias wrote:
> nit: why not keep this inside the for()?

80 columns nonsense, and splitting the for over 3 lines looked dumb.. I'll put
it back inside and forget about 80 cols for now.

[aelias_OOO_until_Jul13, 2012-11-21 02:04:50]

lgtm once that's fixed.

[danakj, 2012-11-21 02:13:48]

PTAL.

I like the change to move those functions a lot, makes the include dependencies
from renderpass much simpler too.

[danakj, 2012-11-21 02:13:58]

On 2012/11/21 02:04:50, aelias wrote:
> lgtm once that's fixed.

Oh, okay thanks :)

[commit-bot: I haz the power, 2012-11-21 04:04:58]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2012-11-21 04:12:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11413106/7002

[commit-bot: I haz the power, 2012-11-21 04:26:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11413106/9023

[commit-bot: I haz the power, 2012-11-21 07:02:19]

Change committed as 168998

[yurys, 2012-11-21 11:58:30]

After this change LayoutTests/css3/filters/effect-reference-ordering-hw.html
started to crash on all platforms. Filed WebKit bug on this:
https://bugs.webkit.org/show_bug.cgi?id=102898