cc: Use skia::RefPtr in place of raw pointers and SkAutoTUnref.

cc: Use skia::RefPtr in place of raw pointers and SkAutoTUnref.

Safe reference counting for skia objects ahoy!

R=jamesr
BUG=163454
Depends on: https://codereview.chromium.org/11418217/
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170889

[danakj, 2012-11-29 22:45:24]

james, here's just the cc/ bits from that huge skia::RefPtr CL

[danakj, 2012-11-29 22:53:05]

+senorblanco as well

[Stephen White, 2012-12-03 19:32:09]

LGTM

https://codereview.chromium.org/11412255/diff/5001/webkit/compositor_bindings...
File webkit/compositor_bindings/web_layer_impl.cc (right):

https://codereview.chromium.org/11412255/diff/5001/webkit/compositor_bindings...
webkit/compositor_bindings/web_layer_impl.cc:244:
m_layer->setFilter(skia::AdoptRef(filter));
It would be nice to clean this one up too, since the semantics don't really make
it clear whether the caller is handing you a ref or not.  I don't think we
should use skia::RefPtr, since it's in the WebKit API, but jamesr might know a
good approach (hide it in an opaque pointer-owning class, or something?)

[danakj, 2012-12-03 20:08:27]

https://codereview.chromium.org/11412255/diff/5001/webkit/compositor_bindings...
File webkit/compositor_bindings/web_layer_impl.cc (right):

https://codereview.chromium.org/11412255/diff/5001/webkit/compositor_bindings...
webkit/compositor_bindings/web_layer_impl.cc:244:
m_layer->setFilter(skia::AdoptRef(filter));
On 2012/12/03 19:32:09, Stephen White wrote:
> It would be nice to clean this one up too, since the semantics don't really
make
> it clear whether the caller is handing you a ref or not.  I don't think we
> should use skia::RefPtr, since it's in the WebKit API, but jamesr might know a
> good approach (hide it in an opaque pointer-owning class, or something?)

Oh! I see the graphics layer is sticking its pointer in a SkAutoTUnref, so it's
not passing its reference. I'll add a call to ref() here.

[danakj, 2012-12-03 20:10:27]

jamesr@ can you owners review please?

[danakj, 2012-12-03 20:11:46]

+cdn for OWNERS/security on the cc_messages.cc change. It is just wrapping the
NULL in a RefPtr().

[jamesr, 2012-12-03 20:15:09]

lgtm

[Cris Neckar, 2012-12-03 20:24:56]

lgtm

[commit-bot: I haz the power, 2012-12-04 00:40:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11412255/5002

[commit-bot: I haz the power, 2012-12-04 00:40:38]

Presubmit check for 11412255-5002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common

Presubmit checks took 1.9s to calculate.

[danakj, 2012-12-04 00:41:35]

+piman for content/ OWNERS

[piman, 2012-12-04 00:44:25]

lgtm

[commit-bot: I haz the power, 2012-12-04 00:45:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11412255/5002

[commit-bot: I haz the power, 2012-12-04 04:41:33]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-04 05:01:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11412255/5002

[commit-bot: I haz the power, 2012-12-04 05:08:17]

Change committed as 170889