Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3645)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 11392004: Remove TabContents from AddBlankTabAt, kill AddBlankTab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_restore_browsertest.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 9c93f18d0f10aba18dc0eeb9adaa8d1a16496895..8f547508c3db526e9f4f89dd9a88332de73bc50b 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1479,7 +1479,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
// Open a popup browser with a single blank foreground tab.
Browser* popup_browser = new Browser(
Browser::CreateParams(Browser::TYPE_POPUP, browser()->profile()));
- chrome::AddBlankTab(popup_browser, true);
+ chrome::AddBlankTabAt(popup_browser, -1, true);
EXPECT_EQ(1, popup_browser->tab_count());
// Now try opening another tab in the popup browser.
@@ -1496,7 +1496,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
// Open an app frame browser with a single blank foreground tab.
Browser* app_browser = new Browser(Browser::CreateParams::CreateForApp(
L"Test", browser()->profile(), false));
- chrome::AddBlankTab(app_browser, true);
+ chrome::AddBlankTabAt(app_browser, -1, true);
EXPECT_EQ(1, app_browser->tab_count());
// Now try opening another tab in the app browser.
@@ -1514,7 +1514,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
// Open an app frame popup browser with a single blank foreground tab.
Browser* app_popup_browser = new Browser(Browser::CreateParams::CreateForApp(
L"Test", browser()->profile(), false));
- chrome::AddBlankTab(app_popup_browser, true);
+ chrome::AddBlankTabAt(app_popup_browser, -1, true);
EXPECT_EQ(1, app_popup_browser->tab_count());
// Now try opening another tab in the app popup browser.
« no previous file with comments | « chrome/browser/sessions/session_restore_browsertest.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698