Issue 11377146: Allow windows ASAN build to work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11377146: Allow windows ASAN build to work (Closed)

Created:
8 years, 1 month ago by iannucci

Modified:
8 years, 1 month ago

Reviewers:
M-A Ruel, Sigurður Ásgeirsson

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@pdb

Visibility:
Public.

Allow windows ASAN build to work Rolls DEPS for syzygy r1083 => r1194. Changelog is too long to put here. BUG=152226 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169136

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	build/all.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View	1	2 chunks	+10 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

iannucci

siggi@, I'd like your lgtm too, since this rolls sygygy up by ~120 revisions :) ...

8 years, 1 month ago (2012-11-21 18:35:20 UTC) #3

iannucci

On 2012/11/21 18:35:20, iannucci wrote: > siggi@, I'd like your lgtm too, since this rolls ...

8 years, 1 month ago (2012-11-21 18:35:59 UTC) #4

Sigurður Ásgeirsson

lgtm - thanks. Note that chrisha@ has similar (but apparently non-conflicting) changes for coverage in ...

8 years, 1 month ago (2012-11-21 19:00:19 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/11377146/9001

8 years, 1 month ago (2012-11-21 19:22:16 UTC) #6

Change committed as 169136