Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: build/common.gypi

Issue 11377146: Allow windows ASAN build to work (Closed) Base URL: http://git.chromium.org/chromium/src.git@pdb
Patch Set: A smaller rev is acceptable here Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index bdd49006875f580c53a7266484954d83982bdd67..ada389b8007b1d9c7a68f919d4e7c94a8733442a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1366,7 +1366,7 @@
'grit_defines': ['-D', 'enable_web_intents_tag'],
}],
- ['asan==1', {
+ ['asan==1 and OS!="win"', {
'clang%': 1,
}],
['asan==1 and OS=="mac"', {
@@ -1749,6 +1749,15 @@
'USE_SKIA=1',
],
}],
+ ['asan==1 and OS=="win"', {
+ # Since asan on windows uses Syzygy, we need /PROFILE turned on to
+ # produce appropriate pdbs.
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'Profile': 'true',
+ },
+ },
+ }], # asan==1 and OS=="win"
['coverage!=0', {
'conditions': [
['OS=="mac" or OS=="ios"', {
« no previous file with comments | « build/all.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698