Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 11412133: Update build settings for coverage on Windows. (Closed)

Created:
8 years, 1 month ago by chrisha
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update build settings for coverage on Windows. The best coverage results are obtained by using a debug build. This requires profile information and non-incremental linking, thus we modify the build settings accordingly. When coverage=0 the build settings are unchanged. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M build/common.gypi View 2 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
chrisha
PTAL. (Feel free to CC anyone who you think should take a look at this.)
8 years, 1 month ago (2012-11-21 16:09:30 UTC) #1
Sigurður Ásgeirsson
lgtm
8 years, 1 month ago (2012-11-21 16:12:48 UTC) #2
chrisha
Thanks, committing.
8 years, 1 month ago (2012-11-22 15:12:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/11412133/1
8 years, 1 month ago (2012-11-22 15:12:58 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-22 17:24:09 UTC) #5
Change committed as 169283

Powered by Google App Engine
This is Rietveld 408576698