Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11366074: Coalesce event router Init calls into their constructors. (Closed)

Created:
8 years, 1 month ago by Yoyo Zhou
Modified:
8 years, 1 month ago
Reviewers:
Aaron Boodman, kaiwang
CC:
chromium-reviews, Aaron Boodman, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Coalesce event router Init calls into their constructors. BUG=159265 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166066

Patch Set 1 #

Total comments: 3

Patch Set 2 : aa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -104 lines) Patch
M chrome/browser/bookmarks/bookmark_extension_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_api.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.h View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/managed_mode/managed_mode_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/managed_mode/managed_mode_api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/window_event_router.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/window_event_router.cc View 2 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yoyo Zhou
8 years, 1 month ago (2012-11-02 23:43:00 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/11366074/diff/1/chrome/browser/extensions/api/cookies/cookies_api.cc File chrome/browser/extensions/api/cookies/cookies_api.cc (right): http://codereview.chromium.org/11366074/diff/1/chrome/browser/extensions/api/cookies/cookies_api.cc#newcode58 chrome/browser/extensions/api/cookies/cookies_api.cc:58: void ExtensionCookiesEventRouter::Observe( insert blank line http://codereview.chromium.org/11366074/diff/1/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc ...
8 years, 1 month ago (2012-11-04 18:43:22 UTC) #2
Yoyo Zhou
http://codereview.chromium.org/11366074/diff/1/chrome/browser/extensions/api/cookies/cookies_api.cc File chrome/browser/extensions/api/cookies/cookies_api.cc (right): http://codereview.chromium.org/11366074/diff/1/chrome/browser/extensions/api/cookies/cookies_api.cc#newcode58 chrome/browser/extensions/api/cookies/cookies_api.cc:58: void ExtensionCookiesEventRouter::Observe( On 2012/11/04 18:43:22, Aaron Boodman wrote: > ...
8 years, 1 month ago (2012-11-05 20:08:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/11366074/11001
8 years, 1 month ago (2012-11-05 20:09:31 UTC) #4
commit-bot: I haz the power
Presubmit check for 11366074-11001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-05 20:09:40 UTC) #5
Yoyo Zhou
+kaiwang for bookmarks
8 years, 1 month ago (2012-11-05 20:14:02 UTC) #6
kaiwang
bookmarks change is extremely simple, so lgtm For further changes on bookmarks, please add other ...
8 years, 1 month ago (2012-11-05 21:14:26 UTC) #7
Yoyo Zhou
On 2012/11/05 21:14:26, kaiwang wrote: > bookmarks change is extremely simple, so lgtm > For ...
8 years, 1 month ago (2012-11-05 21:17:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/11366074/11001
8 years, 1 month ago (2012-11-05 21:22:17 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-11-05 23:13:29 UTC) #10 
Change committed as 166066

Powered by Google App Engine
This is Rietveld 408576698