Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

Issue 11366074: Coalesce event router Init calls into their constructors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: aa Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
index 3b73fa284ce7ad04a244e90d69e7c7979120a24a..d92305af16281e95976783f8079680ab16237206 100644
--- a/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
@@ -46,11 +46,6 @@ namespace glue = api::push_messaging;
PushMessagingEventRouter::PushMessagingEventRouter(Profile* profile)
: profile_(profile) {
-}
-
-PushMessagingEventRouter::~PushMessagingEventRouter() {}
-
-void PushMessagingEventRouter::Init() {
ProfileSyncService* pss = ProfileSyncServiceFactory::GetForProfile(profile_);
// This may be NULL; for example, for the ChromeOS guest user. In these cases,
// just return without setting up anything, since it won't work anyway.
@@ -78,6 +73,8 @@ void PushMessagingEventRouter::Init() {
content::Source<Profile>(profile_->GetOriginalProfile()));
}
+PushMessagingEventRouter::~PushMessagingEventRouter() {}
+
void PushMessagingEventRouter::Shutdown() {
// We need an explicit Shutdown() due to the dependencies among the various
// ProfileKeyedServices. ProfileSyncService depends on ExtensionSystem, so

Powered by Google App Engine
This is Rietveld 408576698