Clang: enable -Wtautological-constant-out-of-range-compare

Clang: enable -Wtautological-constant-out-of-range-compare

This warning was implemented in Clang a couple of weeks ago,
and now our code base is clean enough to enable it.

BUG=151927
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165793

[hans, 2012-11-02 10:49:02]

thakis: Looks like we're ready to enable this!

[Nico, 2012-11-02 15:28:03]

lgtm!

https://codereview.chromium.org/11366060/diff/3002/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11366060/diff/3002/build/common.gypi#newcode2540
build/common.gypi:2540: }],
Remove the whole os==android block here too

https://codereview.chromium.org/11366060/diff/3002/build/common.gypi#newcode3062
build/common.gypi:3062: '-Wno-tautological-constant-out-of-range-compare',
Remove it down here too.

[hans, 2012-11-02 15:34:57]

https://codereview.chromium.org/11366060/diff/3002/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11366060/diff/3002/build/common.gypi#newcode2540
build/common.gypi:2540: }],
On 2012/11/02 15:28:03, Nico wrote:
> Remove the whole os==android block here too

Done.

https://codereview.chromium.org/11366060/diff/3002/build/common.gypi#newcode3062
build/common.gypi:3062: '-Wno-tautological-constant-out-of-range-compare',
On 2012/11/02 15:28:03, Nico wrote:
> Remove it down here too.

Done.

[hans, 2012-11-02 15:36:34]

zelidrag: OWNERS for chrome/browser/chromeos/ ?

[Nico, 2012-11-02 17:33:59]

Let's get this in while the code builds with the warning on. zel: If you have
comments, we can address them post-commit, but it's a fairly harmless one-line
change.

[commit-bot: I haz the power, 2012-11-02 17:36:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/11366060/8001

[commit-bot: I haz the power, 2012-11-02 18:00:00]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[hans, 2012-11-02 20:07:31]

On 2012/11/02 18:00:00, I haz the power (commit-bot) wrote:
> Step "update" is always a major failure.
> Look at the try server FAQ for more details.

Hmm, these failures look unrelated to my patch.

[commit-bot: I haz the power, 2012-11-02 20:07:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/11366060/8001

[zel, 2012-11-02 21:16:49]

lgtm

[commit-bot: I haz the power, 2012-11-02 23:09:08]

Change committed as 165793