Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: build/common.gypi

Issue 11366060: Clang: enable -Wtautological-constant-out-of-range-compare (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address thakis's comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/chromeos/web_socket_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2507 matching lines...) Expand 10 before | Expand all | Expand 10 after
2518 # removed when we change to that. (This is also why we don't 2518 # removed when we change to that. (This is also why we don't
2519 # bother fixing all these cases today.) 2519 # bother fixing all these cases today.)
2520 '-Wno-unnamed-type-template-args', 2520 '-Wno-unnamed-type-template-args',
2521 # This (rightyfully) complains about 'override', which we use 2521 # This (rightyfully) complains about 'override', which we use
2522 # heavily. 2522 # heavily.
2523 '-Wno-c++11-extensions', 2523 '-Wno-c++11-extensions',
2524 2524
2525 # Warns on switches on enums that cover all enum values but 2525 # Warns on switches on enums that cover all enum values but
2526 # also contain a default: branch. Chrome is full of that. 2526 # also contain a default: branch. Chrome is full of that.
2527 '-Wno-covered-switch-default', 2527 '-Wno-covered-switch-default',
2528
2529 # TODO(thakis): Remove this once http://crbug.com/151927 is fixed.
2530 '-Wno-tautological-constant-out-of-range-compare',
2531 ], 2528 ],
2532 'cflags!': [ 2529 'cflags!': [
2533 # Clang doesn't seem to know know this flag. 2530 # Clang doesn't seem to know know this flag.
2534 '-mfpmath=sse', 2531 '-mfpmath=sse',
2535 ], 2532 ],
2536 }], 2533 }],
2537 ['OS=="android"', {
2538 'cflags!': [
2539 # Clang ARM does not support the following option.
2540 # TODO: Add this flag back http://crbug.com/157195.
2541 '-Wno-tautological-constant-out-of-range-compare',
2542 ]
2543 }],
2544 ['clang==1 and clang_use_chrome_plugins==1', { 2534 ['clang==1 and clang_use_chrome_plugins==1', {
2545 'cflags': [ 2535 'cflags': [
2546 '<@(clang_chrome_plugins_flags)', 2536 '<@(clang_chrome_plugins_flags)',
2547 ], 2537 ],
2548 }], 2538 }],
2549 ['clang==1 and clang_load!=""', { 2539 ['clang==1 and clang_load!=""', {
2550 'cflags': [ 2540 'cflags': [
2551 '-Xclang', '-load', '-Xclang', '<(clang_load)', 2541 '-Xclang', '-load', '-Xclang', '<(clang_load)',
2552 ], 2542 ],
2553 }], 2543 }],
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
3053 '-Wno-unused-function', 3043 '-Wno-unused-function',
3054 # See comments on this flag higher up in this file. 3044 # See comments on this flag higher up in this file.
3055 '-Wno-unnamed-type-template-args', 3045 '-Wno-unnamed-type-template-args',
3056 # This (rightyfully) complains about 'override', which we use 3046 # This (rightyfully) complains about 'override', which we use
3057 # heavily. 3047 # heavily.
3058 '-Wno-c++11-extensions', 3048 '-Wno-c++11-extensions',
3059 3049
3060 # Warns on switches on enums that cover all enum values but 3050 # Warns on switches on enums that cover all enum values but
3061 # also contain a default: branch. Chrome is full of that. 3051 # also contain a default: branch. Chrome is full of that.
3062 '-Wno-covered-switch-default', 3052 '-Wno-covered-switch-default',
3063
3064 # TODO(thakis): Remove this once http://crbug.com/151927 is fixe d.
3065 '-Wno-tautological-constant-out-of-range-compare',
3066 ], 3053 ],
3067 }], 3054 }],
3068 ['clang==1 and clang_use_chrome_plugins==1', { 3055 ['clang==1 and clang_use_chrome_plugins==1', {
3069 'OTHER_CFLAGS': [ 3056 'OTHER_CFLAGS': [
3070 '<@(clang_chrome_plugins_flags)', 3057 '<@(clang_chrome_plugins_flags)',
3071 ], 3058 ],
3072 }], 3059 }],
3073 ['clang==1 and clang_load!=""', { 3060 ['clang==1 and clang_load!=""', {
3074 'OTHER_CFLAGS': [ 3061 'OTHER_CFLAGS': [
3075 '-Xclang', '-load', '-Xclang', '<(clang_load)', 3062 '-Xclang', '-load', '-Xclang', '<(clang_load)',
(...skipping 603 matching lines...) Expand 10 before | Expand all | Expand 10 after
3679 # settings in target dicts. SYMROOT is a special case, because many other 3666 # settings in target dicts. SYMROOT is a special case, because many other
3680 # Xcode variables depend on it, including variables such as 3667 # Xcode variables depend on it, including variables such as
3681 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3668 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3682 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3669 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3683 # files to appear (when present) in the UI as actual files and not red 3670 # files to appear (when present) in the UI as actual files and not red
3684 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3671 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3685 # and therefore SYMROOT, needs to be set at the project level. 3672 # and therefore SYMROOT, needs to be set at the project level.
3686 'SYMROOT': '<(DEPTH)/xcodebuild', 3673 'SYMROOT': '<(DEPTH)/xcodebuild',
3687 }, 3674 },
3688 } 3675 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/web_socket_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698