Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: build/common.gypi

Issue 11366060: Clang: enable -Wtautological-constant-out-of-range-compare (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address thakis's comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/web_socket_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 569772f121f601f5e81c3740f79b2232c2df08b0..e45863d339a65bb4a779ab3332a03056d842dc08 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2525,22 +2525,12 @@
# Warns on switches on enums that cover all enum values but
# also contain a default: branch. Chrome is full of that.
'-Wno-covered-switch-default',
-
- # TODO(thakis): Remove this once http://crbug.com/151927 is fixed.
- '-Wno-tautological-constant-out-of-range-compare',
],
'cflags!': [
# Clang doesn't seem to know know this flag.
'-mfpmath=sse',
],
}],
- ['OS=="android"', {
- 'cflags!': [
- # Clang ARM does not support the following option.
- # TODO: Add this flag back http://crbug.com/157195.
- '-Wno-tautological-constant-out-of-range-compare',
- ]
- }],
['clang==1 and clang_use_chrome_plugins==1', {
'cflags': [
'<@(clang_chrome_plugins_flags)',
@@ -3060,9 +3050,6 @@
# Warns on switches on enums that cover all enum values but
# also contain a default: branch. Chrome is full of that.
'-Wno-covered-switch-default',
-
- # TODO(thakis): Remove this once http://crbug.com/151927 is fixed.
- '-Wno-tautological-constant-out-of-range-compare',
],
}],
['clang==1 and clang_use_chrome_plugins==1', {
« no previous file with comments | « no previous file | chrome/browser/chromeos/web_socket_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698