Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11364196: Remove TabContents from TabStripModelObserver::ActiveTabChanged. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, melevin, sadrul, ben+watch_chromium.org, tfarina, samarth, gideonwald, sreeram, dominich, Aaron Boodman, David Black, chromium-apps-reviews_chromium.org, Jered
Visibility:
Public.

Description

Remove TabContents from TabStripModelObserver::ActiveTabChanged. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167359

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fixes #

Patch Set 5 : fix #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -143 lines) Patch
M chrome/browser/extensions/browser_event_router.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc View 1 2 3 7 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_prompt_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_prompt_controller.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 3 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 2 3 4 5 6 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_order_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_order_controller.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 3 4 5 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 4 5 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 10 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years, 1 month ago (2012-11-12 16:52:09 UTC) #1
sky
LGTM
8 years, 1 month ago (2012-11-12 22:02:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11364196/11001
8 years, 1 month ago (2012-11-13 01:45:46 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-13 03:57:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11364196/11001
8 years, 1 month ago (2012-11-13 04:29:40 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 10:32:15 UTC) #6 
Change committed as 167359

Powered by Google App Engine
This is Rietveld 408576698