chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 11364196: Remove TabContents from TabStripModelObserver::ActiveTabChanged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 11364196: Remove TabContents from TabStripModelObserver::ActiveTabChanged. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

index 5b5c21a0cd8b7d6f4fc09f78d1555e74c4e0439e..53d84059a73eeea22c669c9ede3d4bded9ffd5dd 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

@@ -1298,7 +1298,7 @@ private:

DCHECK_EQ(oldContents, [oldController webContents]);

// Simply create a new TabContentsController for |newContents| and place it

- // into the array, replacing |oldContents|. A ActiveTabChanged notification

+ // into the array, replacing |oldContents|. An ActiveTabChanged notification

// will follow, at which point we will install the new view.

scoped_nsobject<TabContentsController> newController(

[[TabContentsController alloc] initWithContents:newContents]);