Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar shortcuts owned by the uni…

Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar shortcuts owned by the uninstalled Chrome.

TBR=brettw@chromium.org
BUG=158632
TEST=No user-level shortcut Chrome left behind in taskbar post user-level self-destruct.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165505

[gab, 2012-10-31 19:00:36]

@robertshield for logic in chrome\installer\*
@brettw for OWNER approval on side-effects in base\* and
chrome\browser\shell_integration_win.cc.

Thanks!
Gab

[robertshield, 2012-10-31 19:41:48]

https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninst...
File chrome/installer/setup/uninstall.cc (right):

https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninst...
chrome/installer/setup/uninstall.cc:311: 
in the walk to the train, I've forgotten why this is needed since right above we
are calling RemoveChromeShortcut on all the shortcuts we own, and in theory that
method also performs unpinning. Could you add a comment explaining this?

[gab, 2012-10-31 20:04:59]

Comment added.

https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninst...
File chrome/installer/setup/uninstall.cc (right):

https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninst...
chrome/installer/setup/uninstall.cc:311: 
On 2012/10/31 19:41:48, robertshield wrote:
> in the walk to the train, I've forgotten why this is needed since right above
we
> are calling RemoveChromeShortcut on all the shortcuts we own, and in theory
that
> method also performs unpinning. Could you add a comment explaining this?

Done.

[robertshield, 2012-10-31 20:27:18]

lgtm

[gab, 2012-10-31 20:49:20]

Thanks,

@brettw for OWNER on base and chrome\browser small changes.

[gab, 2012-11-01 15:27:59]

@brettw: ping

[gab, 2012-11-01 19:56:39]

On 2012/11/01 15:27:59, gab wrote:
> @brettw: ping

TBR: brettw

[commit-bot: I haz the power, 2012-11-01 19:56:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11361015/1007

[brettw, 2012-11-01 20:05:18]

LGTM. Please wait for review next time you add stuff to base or find another
reviewer. 1 day is basically my min latency these days, and additions aren't
always as trivial as they look.

[gab, 2012-11-01 20:06:13]

On 2012/11/01 20:05:18, brettw wrote:
> LGTM. Please wait for review next time you add stuff to base or find another
> reviewer. 1 day is basically my min latency these days, and additions aren't
> always as trivial as they look.

Ok, thanks.

[commit-bot: I haz the power, 2012-11-01 21:33:32]

Change committed as 165505