Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5374)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 11361015: Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar shortcuts owned by the uni… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comment in uninstall.cc Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | chrome/installer/util/shell_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 2fb193b801d739f67c339aa1ae25dc8ecc1d9c93..5c6e6c5dd009bf75c0a72b8661bdcf75006ea9df 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -307,6 +307,13 @@ void DeleteChromeShortcuts(const InstallerState& installer_state,
LOG(WARNING) << "Failed to delete Start Menu shortcuts.";
}
+ // Although the shortcut removal calls above will unpin their shortcut if they
+ // result in a deletion (i.e. shortcut existed and pointed to |chrome_exe|),
+ // it is possible for shortcuts to remain pinned while their parent shortcut
+ // has been deleted or changed to point to another |chrome_exe|. Make sure all
+ // pinned-to-taskbar shortcuts that point to |chrome_exe| are unpinned.
+ ShellUtil::RemoveChromeTaskbarShortcuts(chrome_exe);
+
ShellUtil::RemoveChromeStartScreenShortcuts(product.distribution(),
chrome_exe);
}
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | chrome/installer/util/shell_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698