Chromium Code Reviews
Help | Chromium Project | Sign in
(444)

Issue 11361015: Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar shortcuts owned by the uni… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by gab
Modified:
1 year, 5 months ago
Reviewers:
brettw, robertshield
CC:
chromium-reviews_chromium.org, grt+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar shortcuts owned by the uninstalled Chrome.

TBR=brettw@chromium.org
BUG=158632
TEST=No user-level shortcut Chrome left behind in taskbar post user-level self-destruct.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165505

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment in uninstall.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Lint Patch
M base/base_paths_win.h View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M base/base_paths_win.cc View 1 chunk +6 lines, -0 lines 0 comments ? errors Download
M chrome/browser/shell_integration_win.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M chrome/installer/setup/uninstall.cc View 1 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M chrome/installer/util/shell_util.h View 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M chrome/installer/util/shell_util.cc View 1 chunk +28 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 11
gab
@robertshield for logic in chrome\installer\* @brettw for OWNER approval on side-effects in base\* and chrome\browser\shell_integration_win.cc. ...
1 year, 5 months ago #1
robertshield
https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninstall.cc File chrome/installer/setup/uninstall.cc (right): https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninstall.cc#newcode311 chrome/installer/setup/uninstall.cc:311: in the walk to the train, I've forgotten why ...
1 year, 5 months ago #2
gab
Comment added. https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninstall.cc File chrome/installer/setup/uninstall.cc (right): https://codereview.chromium.org/11361015/diff/1/chrome/installer/setup/uninstall.cc#newcode311 chrome/installer/setup/uninstall.cc:311: On 2012/10/31 19:41:48, robertshield wrote: > in ...
1 year, 5 months ago #3
robertshield
lgtm
1 year, 5 months ago #4
gab
Thanks, @brettw for OWNER on base and chrome\browser small changes.
1 year, 5 months ago #5
gab
@brettw: ping
1 year, 5 months ago #6
gab
On 2012/11/01 15:27:59, gab wrote: > @brettw: ping TBR: brettw
1 year, 5 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/11361015/1007
1 year, 5 months ago #8
brettw
LGTM. Please wait for review next time you add stuff to base or find another ...
1 year, 5 months ago #9
gab
On 2012/11/01 20:05:18, brettw wrote: > LGTM. Please wait for review next time you add ...
1 year, 5 months ago #10
I haz the power (commit-bot)
1 year, 5 months ago #11
Change committed as 165505
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6