Issue 11316245: Move VisibilityController to corewm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316245: Move VisibilityController to corewm. (Closed)

Created:
8 years ago by Ben Goodger (Google)

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move VisibilityController to corewm. I had to add a subclass to Ash for the time being to allow Ash to call its method for animating windows, which handles a few animation types corewm doesn't know about. I'd like to clean this up a bit in a future CL, see my TODO. http://crbug.com/158115 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170328

Patch Set 1 : #

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -282 lines)			Patch
M	ash/ash.gyp	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	ash/root_window_controller.cc	View	1	9 chunks	+14 lines, -10 lines	0 comments	Download
M	ash/shell.h	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/shell.cc	View	1	4 chunks	+21 lines, -2 lines	0 comments	Download
D	ash/wm/visibility_controller.h	View	1	1 chunk	+0 lines, -67 lines	0 comments	Download
D	ash/wm/visibility_controller.cc	View	1	1 chunk	+0 lines, -78 lines	0 comments	Download
D	ash/wm/visibility_controller_unittest.cc	View	1	1 chunk	+0 lines, -50 lines	0 comments	Download
M	ash/wm/window_properties.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	ash/wm/window_properties.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/wm/workspace/workspace.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views.cc	View	1	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/desktop_browser_frame_aura.h	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc	View	1	3 chunks	+3 lines, -7 lines	0 comments	Download
A +	ui/views/corewm/visibility_controller.h	View	1	3 chunks	+21 lines, -13 lines	0 comments	Download
A +	ui/views/corewm/visibility_controller.cc	View	1	3 chunks	+29 lines, -20 lines	0 comments	Download
A +	ui/views/corewm/visibility_controller_unittest.cc	View	1	3 chunks	+16 lines, -11 lines	0 comments	Download
M	ui/views/views.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages