Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 11308270: Remove unused parameter from the method IsDomainMatch of the class CanonicalCookie (Closed)

Created:
8 years ago by markusheintz_
Modified:
8 years ago
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove unused parameter from the method IsDomainMatch of the class CanonicalCookie. TEST=CanonicalCookie* BUG=163349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M net/cookies/canonical_cookie.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/canonical_cookie.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/cookies/canonical_cookie_unittest.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M net/cookies/cookie_monster.cc View 4 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
markusheintz_
Hey Erik please review this CL. Thanks a lot
8 years ago (2012-11-29 14:32:09 UTC) #1
erikwright (departed)
LGTM. Thank you!
8 years ago (2012-11-30 05:18:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/11308270/1
8 years ago (2012-11-30 11:49:36 UTC) #3
commit-bot: I haz the power
8 years ago (2012-11-30 12:56:26 UTC) #4
Message was sent while issue was closed.
Change committed as 170442

Powered by Google App Engine
This is Rietveld 408576698