Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: net/cookies/canonical_cookie_unittest.cc

Issue 11308270: Remove unused parameter from the method IsDomainMatch of the class CanonicalCookie (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/canonical_cookie.cc ('k') | net/cookies/cookie_monster.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/canonical_cookie_unittest.cc
diff --git a/net/cookies/canonical_cookie_unittest.cc b/net/cookies/canonical_cookie_unittest.cc
index 9951db08dff636d8e4490394ab56c4dba2a7f444..b46a3f2fa7950ab1b125f58190e02934f666d6ba 100644
--- a/net/cookies/canonical_cookie_unittest.cc
+++ b/net/cookies/canonical_cookie_unittest.cc
@@ -201,30 +201,30 @@ TEST(CanonicalCookieTest, IsDomainMatch) {
scoped_ptr<CanonicalCookie> cookie(
CanonicalCookie::Create(url, "A=2", creation_time, options));
EXPECT_TRUE(cookie->IsHostCookie());
- EXPECT_TRUE(cookie->IsDomainMatch("http", "www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("https", "www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("http", "foo.www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("http", "www0.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("http", "example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
+ EXPECT_FALSE(cookie->IsDomainMatch("foo.www.example.com"));
+ EXPECT_FALSE(cookie->IsDomainMatch("www0.example.com"));
+ EXPECT_FALSE(cookie->IsDomainMatch("example.com"));
cookie.reset(
CanonicalCookie::Create(url, "A=2; Domain=www.example.com", creation_time,
options));
EXPECT_TRUE(cookie->IsDomainCookie());
- EXPECT_TRUE(cookie->IsDomainMatch("http", "www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("https", "www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("http", "foo.www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("http", "www0.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("http", "example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("foo.www.example.com"));
+ EXPECT_FALSE(cookie->IsDomainMatch("www0.example.com"));
+ EXPECT_FALSE(cookie->IsDomainMatch("example.com"));
cookie.reset(
CanonicalCookie::Create(url, "A=2; Domain=.www.example.com",
creation_time, options));
- EXPECT_TRUE(cookie->IsDomainMatch("http", "www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("https", "www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("http", "foo.www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("http", "www0.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("http", "example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
+ EXPECT_TRUE(cookie->IsDomainMatch("foo.www.example.com"));
+ EXPECT_FALSE(cookie->IsDomainMatch("www0.example.com"));
+ EXPECT_FALSE(cookie->IsDomainMatch("example.com"));
}
TEST(CanonicalCookieTest, IsOnPath) {
« no previous file with comments | « net/cookies/canonical_cookie.cc ('k') | net/cookies/cookie_monster.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698