Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: net/cookies/cookie_monster.cc

Issue 11308270: Remove unused parameter from the method IsDomainMatch of the class CanonicalCookie (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/canonical_cookie_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.cc
diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc
index 59f3cf87d37fa2988926bf5f1d041c73aea298d2..3397628003a1795750a0f7db45b4ef399267c568 100644
--- a/net/cookies/cookie_monster.cc
+++ b/net/cookies/cookie_monster.cc
@@ -1133,7 +1133,6 @@ int CookieMonster::DeleteAllForHost(const GURL& url) {
if (!HasCookieableScheme(url))
return 0;
- const std::string scheme(url.scheme());
const std::string host(url.host());
// We store host cookies in the store by their canonical host name;
@@ -1148,7 +1147,7 @@ int CookieMonster::DeleteAllForHost(const GURL& url) {
const CanonicalCookie* const cc = curit->second;
// Delete only on a match as a host cookie.
- if (cc->IsHostCookie() && cc->IsDomainMatch(scheme, host)) {
+ if (cc->IsHostCookie() && cc->IsDomainMatch(host)) {
num_deleted++;
InternalDeleteCookie(curit, true, DELETE_COOKIE_EXPLICIT);
@@ -1603,7 +1602,6 @@ void CookieMonster::FindCookiesForKey(
std::vector<CanonicalCookie*>* cookies) {
lock_.AssertAcquired();
- const std::string scheme(url.scheme());
const std::string host(url.host());
bool secure = url.SchemeIsSecure();
@@ -1628,7 +1626,7 @@ void CookieMonster::FindCookiesForKey(
continue;
// Filter out cookies that don't apply to this domain.
- if (!cc->IsDomainMatch(scheme, host))
+ if (!cc->IsDomainMatch(host))
continue;
if (!cc->IsOnPath(url.path()))
« no previous file with comments | « net/cookies/canonical_cookie_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698