Issue 11308066: Rename IsAsciiRepresentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308066: Rename IsAsciiRepresentation (Closed)

Created:
8 years, 1 month ago by drcarney

Modified:
8 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Rename IsAsciiRepresentation This is a straight rename: IsAsciiRepresentation -> IsOneByteRepresentation IsAsciiRepresentationUnderneath -> IsOneByteRepresentationUnderneath AllocateRawAsciiString -> AllocateRawOneByteString AllocateStringFromAscii -> AllocateStringFromOneByte R=yangguo@chromium.org, BUG= Committed: https://code.google.com/p/v8/source/detail?r=13023

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -86 lines)			Patch
M	src/api.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/arm/regexp-macro-assembler-arm.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/extensions/externalize-string-extension.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/handles.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/heap.cc	View	12 chunks	+16 lines, -15 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/jsregexp.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/log-utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	7 chunks	+9 lines, -8 lines	0 comments	Download
M	src/objects-inl.h	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/regexp-macro-assembler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	18 chunks	+19 lines, -19 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-alloc.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM. Landing.

Expand Messages | Collapse Messages