Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: src/extensions/externalize-string-extension.cc

Issue 11308066: Rename IsAsciiRepresentation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 return v8::ThrowException(v8::String::New( 86 return v8::ThrowException(v8::String::New(
87 "Second parameter to externalizeString() must be a boolean.")); 87 "Second parameter to externalizeString() must be a boolean."));
88 } 88 }
89 } 89 }
90 bool result = false; 90 bool result = false;
91 Handle<String> string = Utils::OpenHandle(*args[0].As<v8::String>()); 91 Handle<String> string = Utils::OpenHandle(*args[0].As<v8::String>());
92 if (string->IsExternalString()) { 92 if (string->IsExternalString()) {
93 return v8::ThrowException(v8::String::New( 93 return v8::ThrowException(v8::String::New(
94 "externalizeString() can't externalize twice.")); 94 "externalizeString() can't externalize twice."));
95 } 95 }
96 if (string->IsAsciiRepresentation() && !force_two_byte) { 96 if (string->IsOneByteRepresentation() && !force_two_byte) {
97 char* data = new char[string->length()]; 97 char* data = new char[string->length()];
98 String::WriteToFlat(*string, data, 0, string->length()); 98 String::WriteToFlat(*string, data, 0, string->length());
99 SimpleAsciiStringResource* resource = new SimpleAsciiStringResource( 99 SimpleAsciiStringResource* resource = new SimpleAsciiStringResource(
100 data, string->length()); 100 data, string->length());
101 result = string->MakeExternal(resource); 101 result = string->MakeExternal(resource);
102 if (result && !string->IsSymbol()) { 102 if (result && !string->IsSymbol()) {
103 HEAP->external_string_table()->AddString(*string); 103 HEAP->external_string_table()->AddString(*string);
104 } 104 }
105 if (!result) delete resource; 105 if (!result) delete resource;
106 } else { 106 } else {
(...skipping 13 matching lines...) Expand all
120 return v8::Undefined(); 120 return v8::Undefined();
121 } 121 }
122 122
123 123
124 v8::Handle<v8::Value> ExternalizeStringExtension::IsAscii( 124 v8::Handle<v8::Value> ExternalizeStringExtension::IsAscii(
125 const v8::Arguments& args) { 125 const v8::Arguments& args) {
126 if (args.Length() != 1 || !args[0]->IsString()) { 126 if (args.Length() != 1 || !args[0]->IsString()) {
127 return v8::ThrowException(v8::String::New( 127 return v8::ThrowException(v8::String::New(
128 "isAsciiString() requires a single string argument.")); 128 "isAsciiString() requires a single string argument."));
129 } 129 }
130 return Utils::OpenHandle(*args[0].As<v8::String>())->IsAsciiRepresentation() ? 130 return
131 Utils::OpenHandle(*args[0].As<v8::String>())->IsOneByteRepresentation() ?
131 v8::True() : v8::False(); 132 v8::True() : v8::False();
132 } 133 }
133 134
134 135
135 void ExternalizeStringExtension::Register() { 136 void ExternalizeStringExtension::Register() {
136 static ExternalizeStringExtension externalize_extension; 137 static ExternalizeStringExtension externalize_extension;
137 static v8::DeclareExtension declaration(&externalize_extension); 138 static v8::DeclareExtension declaration(&externalize_extension);
138 } 139 }
139 140
140 } } // namespace v8::internal 141 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698