Remove TabContents from TabStripModelObserverBridge.

Remove TabContents from TabStripModelObserverBridge.

BUG=107201
TEST=no visible change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164553

[Robert Sesek, 2012-10-26 19:37:13]

lgtm

https://codereview.chromium.org/11305008/diff/5001/chrome/browser/ui/cocoa/ta...
File chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm (right):

https://codereview.chromium.org/11305008/diff/5001/chrome/browser/ui/cocoa/ta...
chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm:13:
content::WebContents WebContentsOf(TabContents* tab_contents) {
WebContents*

[Avi (use Gerrit), 2012-10-26 20:06:17]

Yes, of course. Silly me.

[commit-bot: I haz the power, 2012-10-26 20:10:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/11305008/7011

[commit-bot: I haz the power, 2012-10-26 20:10:59]

Failed to apply patch for chrome/browser/ui/cocoa/browser_window_controller.mm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/cocoa/browser_window_controller.mm
  Hunk #1 FAILED at 1551.
  Hunk #2 succeeded at 1575 with fuzz 1 (offset -5 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/cocoa/browser_window_controller.mm.rej

Patch:       chrome/browser/ui/cocoa/browser_window_controller.mm
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm
b/chrome/browser/ui/cocoa/browser_window_controller.mm
index
5bf5d07407aace99a8e9ce0e97008f686b7457f3..8da07103d9fb5e2466cfc8e2449d679d8c958935
100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1551,9 +1551,7 @@ enum {
   // applicable)?
   [self updateBookmarkBarVisibilityWithAnimation:NO];
 
-  TabContents* tabContents = TabContents::FromWebContents(contents);
-  // Without the .get(), xcode fails.
-  [infoBarContainerController_.get() changeTabContents:tabContents];
+  [infoBarContainerController_ changeWebContents:contents];
 }
 
 - (void)onReplaceTabWithContents:(WebContents*)contents {
@@ -1580,8 +1578,7 @@ enum {
 }
 
 - (void)onTabDetachedWithContents:(WebContents*)contents {
-  TabContents* tabContents = TabContents::FromWebContents(contents);
-  [infoBarContainerController_ tabDetachedWithContents:tabContents];
+  [infoBarContainerController_ tabDetachedWithContents:contents];
 }
 
 - (void)onInsertTabWithContents:(WebContents*)contents {

[commit-bot: I haz the power, 2012-10-26 20:46:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/11305008/8002

[commit-bot: I haz the power, 2012-10-26 22:47:09]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for dinner.
Ping the relevant dude on a on-needed basis.

[commit-bot: I haz the power, 2012-10-27 15:59:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/11305008/8002

[commit-bot: I haz the power, 2012-10-27 18:28:43]

Change committed as 164553