chrome/browser/ui/cocoa/hung_renderer_controller.mm - Issue 11305008: Remove TabContents from TabStripModelObserverBridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/hung_renderer_controller.mm

Issue 11305008: Remove TabContents from TabStripModelObserverBridge. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/hung_renderer_controller.mm

diff --git a/chrome/browser/ui/cocoa/hung_renderer_controller.mm b/chrome/browser/ui/cocoa/hung_renderer_controller.mm

index 12529acd18af6f2d86a922c43435a1d9097b7062..1ebc1fab3afdcc6ff28554df586f1b70e6d56cd8 100644

--- a/chrome/browser/ui/cocoa/hung_renderer_controller.mm

+++ b/chrome/browser/ui/cocoa/hung_renderer_controller.mm

@@ -175,11 +175,11 @@ class WebContentsObserverBridge : public content::WebContentsObserver {

for (TabContentsIterator it; !it.done(); ++it) {

if (it->web_contents()->GetRenderProcessHost() ==

hungContents_->GetRenderProcessHost()) {

- string16 title = (*it)->web_contents()->GetTitle();

+ string16 title = it->web_contents()->GetTitle();

if (title.empty())

title = CoreTabHelper::GetDefaultTitle();

[titles addObject:base::SysUTF16ToNSString(title)];

- [favicons addObject:mac::FaviconForTabContents(*it)];

+ [favicons addObject:mac::FaviconForWebContents(it->web_contents())];

}

hungTitles_.reset([titles copy]);