Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: net/base/upload_bytes_element_reader_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/tcp_listen_socket.cc ('k') | net/cookies/cookie_monster_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/upload_bytes_element_reader_unittest.cc
diff --git a/net/base/upload_bytes_element_reader_unittest.cc b/net/base/upload_bytes_element_reader_unittest.cc
index 1a3c5d4ebe21c8a4aecaaed9c08737f5925ee68a..486a6556d77e2255c88f2b8804259c80725c1831 100644
--- a/net/base/upload_bytes_element_reader_unittest.cc
+++ b/net/base/upload_bytes_element_reader_unittest.cc
@@ -34,7 +34,7 @@ TEST_F(UploadBytesElementReaderTest, ReadPartially) {
std::vector<char> buf(kHalfSize);
scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);
EXPECT_EQ(static_cast<int>(buf.size()),
- reader_->ReadSync(wrapped_buffer, buf.size()));
+ reader_->ReadSync(wrapped_buffer.get(), buf.size()));
EXPECT_EQ(bytes_.size() - buf.size(), reader_->BytesRemaining());
bytes_.resize(kHalfSize); // Resize to compare.
EXPECT_EQ(bytes_, buf);
@@ -44,11 +44,11 @@ TEST_F(UploadBytesElementReaderTest, ReadAll) {
std::vector<char> buf(bytes_.size());
scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);
EXPECT_EQ(static_cast<int>(buf.size()),
- reader_->ReadSync(wrapped_buffer, buf.size()));
+ reader_->ReadSync(wrapped_buffer.get(), buf.size()));
EXPECT_EQ(0U, reader_->BytesRemaining());
EXPECT_EQ(bytes_, buf);
// Try to read again.
- EXPECT_EQ(0, reader_->ReadSync(wrapped_buffer, buf.size()));
+ EXPECT_EQ(0, reader_->ReadSync(wrapped_buffer.get(), buf.size()));
}
TEST_F(UploadBytesElementReaderTest, ReadTooMuch) {
@@ -56,7 +56,7 @@ TEST_F(UploadBytesElementReaderTest, ReadTooMuch) {
std::vector<char> buf(kTooLargeSize);
scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);
EXPECT_EQ(static_cast<int>(bytes_.size()),
- reader_->ReadSync(wrapped_buffer, buf.size()));
+ reader_->ReadSync(wrapped_buffer.get(), buf.size()));
EXPECT_EQ(0U, reader_->BytesRemaining());
buf.resize(bytes_.size()); // Resize to compare.
EXPECT_EQ(bytes_, buf);
« no previous file with comments | « net/base/tcp_listen_socket.cc ('k') | net/cookies/cookie_monster_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698