net/base/upload_bytes_element_reader_unittest.cc - Issue 11275088: Remove implicit scoped_refptr operator T*

Side by Side Diff: net/base/upload_bytes_element_reader_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/base/tcp_listen_socket.cc ('k') | net/cookies/cookie_monster_perftest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/base/upload_bytes_element_reader.h"	5 #include "net/base/upload_bytes_element_reader.h"

6	6

7 #include "base/basictypes.h"	7 #include "base/basictypes.h"

8 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

9 #include "net/base/io_buffer.h"	9 #include "net/base/io_buffer.h"

10 #include "net/base/net_errors.h"	10 #include "net/base/net_errors.h"

(...skipping 16 matching lines...) Expand all Loading...
27	27

28 std::vector<char> bytes_;	28 std::vector<char> bytes_;

29 scoped_ptr<UploadElementReader> reader_;	29 scoped_ptr<UploadElementReader> reader_;

30 };	30 };

31	31

32 TEST_F(UploadBytesElementReaderTest, ReadPartially) {	32 TEST_F(UploadBytesElementReaderTest, ReadPartially) {

33 const size_t kHalfSize = bytes_.size() / 2;	33 const size_t kHalfSize = bytes_.size() / 2;

34 std::vector<char> buf(kHalfSize);	34 std::vector<char> buf(kHalfSize);

35 scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);	35 scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);

36 EXPECT_EQ(static_cast<int>(buf.size()),	36 EXPECT_EQ(static_cast<int>(buf.size()),

37 reader_->ReadSync(wrapped_buffer, buf.size()));	37 reader_->ReadSync(wrapped_buffer.get(), buf.size()));

38 EXPECT_EQ(bytes_.size() - buf.size(), reader_->BytesRemaining());	38 EXPECT_EQ(bytes_.size() - buf.size(), reader_->BytesRemaining());

39 bytes_.resize(kHalfSize); // Resize to compare.	39 bytes_.resize(kHalfSize); // Resize to compare.

40 EXPECT_EQ(bytes_, buf);	40 EXPECT_EQ(bytes_, buf);

41 }	41 }

42	42

43 TEST_F(UploadBytesElementReaderTest, ReadAll) {	43 TEST_F(UploadBytesElementReaderTest, ReadAll) {

44 std::vector<char> buf(bytes_.size());	44 std::vector<char> buf(bytes_.size());

45 scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);	45 scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);

46 EXPECT_EQ(static_cast<int>(buf.size()),	46 EXPECT_EQ(static_cast<int>(buf.size()),

47 reader_->ReadSync(wrapped_buffer, buf.size()));	47 reader_->ReadSync(wrapped_buffer.get(), buf.size()));

48 EXPECT_EQ(0U, reader_->BytesRemaining());	48 EXPECT_EQ(0U, reader_->BytesRemaining());

49 EXPECT_EQ(bytes_, buf);	49 EXPECT_EQ(bytes_, buf);

50 // Try to read again.	50 // Try to read again.

51 EXPECT_EQ(0, reader_->ReadSync(wrapped_buffer, buf.size()));	51 EXPECT_EQ(0, reader_->ReadSync(wrapped_buffer.get(), buf.size()));

52 }	52 }

53	53

54 TEST_F(UploadBytesElementReaderTest, ReadTooMuch) {	54 TEST_F(UploadBytesElementReaderTest, ReadTooMuch) {

55 const size_t kTooLargeSize = bytes_.size() * 2;	55 const size_t kTooLargeSize = bytes_.size() * 2;

56 std::vector<char> buf(kTooLargeSize);	56 std::vector<char> buf(kTooLargeSize);

57 scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);	57 scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);

58 EXPECT_EQ(static_cast<int>(bytes_.size()),	58 EXPECT_EQ(static_cast<int>(bytes_.size()),

59 reader_->ReadSync(wrapped_buffer, buf.size()));	59 reader_->ReadSync(wrapped_buffer.get(), buf.size()));

60 EXPECT_EQ(0U, reader_->BytesRemaining());	60 EXPECT_EQ(0U, reader_->BytesRemaining());

61 buf.resize(bytes_.size()); // Resize to compare.	61 buf.resize(bytes_.size()); // Resize to compare.

62 EXPECT_EQ(bytes_, buf);	62 EXPECT_EQ(bytes_, buf);

63 }	63 }

64	64

65 } // namespace net	65 } // namespace net

OLD	NEW